Create vets-api Endpoint and E2E connection for VAMC Banners (Story 6)

Agile6MSkinner commented 1 month ago

Description

Build a production vets-api endpoint that retrieves banner data from the database and serves it to the frontend banner component, ensuring that banner content is up-to-date and dynamically served in production environments on the specific location passed via path from #19451.

Sequence Note: This task must be completed last before E2E testing in #19465

Testing & QA

Automated Testing

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

Functional testing:
Code review:
Design review:
Accessibility review:
Product acceptance:

Acceptance criteria

_ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable._

[ ] vets-api endpoint reads production data from the database.
[ ] Data is correctly provided to the frontend banner.
[ ] End-to-end test ensuring the banner displays correctly in production environments.
[ ] Impact analysis is filled out and QA test plan is updated accordingly
[ ] Does this product have an existing regression test plan?
- [ ] Yes, link:
- [ ] No, regression test plan will be created as part of the work / points in this ticket

Agile6MSkinner commented 1 month ago

We ran out of brain. Will finish at next refinement.

jilladams commented 1 month ago

Stories 1-5 are in sprint 15. They might reveal things we need to keep in mind when we get to it.

dsasser commented 2 weeks ago

Removed these ACs since this is an API and there are no UX/Accessibility concerns to address:

[ ] Design review?
[ ] Accessibility review?

dsasser commented 1 week ago

End of Sprint Update 11-8-24

The work is in PR pending review from our team, and then from platform as well, which has a 3 day grace period once our team signs off. I'm also not sure if we are blocked on merging because of the status of the collab review or not.

Agile6MSkinner commented 1 week ago

@dsasser I would think no? There's no harm in an endpoint being out there if nothing's happening with it, right?

dsasser commented 1 week ago

@dsasser I would think no? There's no harm in an endpoint being out there if nothing's happening with it, right?

Agreed it is benign until we pull the launch trigger (flip the flippers).

jilladams commented 6 days ago

In PR, blocked on Platform review. (day 2 waiting of 3)

dsasser commented 3 days ago

PR has been approved and merged.

department-of-veterans-affairs / va.gov-cms