VAMC real-time banners tech debt cleanup: remove flipper / feature toggle logic and flippers/ toggles

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.

https://prod.cms.va.gov

GNU General Public License v2.0

99 stars 69 forks source link

Open jilladams opened 1 month ago

jilladams commented 1 month ago

If we have created flippers for banner_use_alternative_banners in vets-api or CMS feature toggles, we need to:

[ ] Update the logic in FE templates to no longer be conditional / use the toggles
[ ] Remove CMS feature toggle: feature_banner_use_alternative_banners
[ ] Remove vets-api flipper: banner_use_alternative_banners
- [ ] Ask Platform support to run the sidekiq script that updates prod flippers, and will remove the flipper from the UI after our code change, e.g. https://dsva.slack.com/archives/CBU0KDSB1/p1730397715213859

Agile6MSkinner commented 2 weeks ago

Calling this refined, but @SnowboardTechie needs to get the Flipper/Toggle names into the ticket. If they're not here yet, go after him.

SnowboardTechie commented 2 weeks ago

jilladams commented 2 weeks ago

WHen we pick this up, double check with Bryan / Daniel that the listed flipper names haven't changed - should be easy to tell in prod:

CMS feature toggle: feature_banner_use_alternative_banners - https://prod.cms.va.gov/admin/config/system/feature_toggle
vets-api flipper: banner_use_alternative_banners - https://api.va.gov/flipper/features