department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

Drupal UX for Staff Profile, VAMC Billing & Insurance, VAMC Facility mental health phone number #19512

Open davidmpickett opened 3 days ago

davidmpickett commented 3 days ago

[2024-10-16] Not blocking shipping CMS changes behind a toggle, but IS launch blocking for change management / editor comms.

Description

AS A Drupal VAMC editor I NEED to understand which fields are required or optional SO I CAN enter timely and accurate data

These three content types are changing from a single non-required field to a paragraph type for phone number entry

Old phone number field example

Image

New phone paragraph example

Image

Both of the inputs above are optional. However, the paragraph form is a little confusing because A) it has required subfields & B) we are automatically populating 1 on New Nodes and C) editors would have to use a hidden menu option to remove the default.

An alternative would be to have 0 phones populate by default. However, right now that UI feels a bit empty. We could update that UI to look more like it does on Service Locations which defaults to 0, but gives more prompting.

1 default with hidden Menu

Image

Alternative 0 default that feels empty

Image

What we do on Service Locations

Image

Acceptance criteria

_ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable._

jilladams commented 2 days ago

In sprint 15: Jordan may not have time to address before Dave is back from PTO

The conversation from scrum: https://dsva.slack.com/archives/C079GFKN50D/p1729007496363379?thread_ts=1728955309.898119&cid=C079GFKN50D

Staff Profile = guess: ~75% of those have #s Mental Health Phone = should feel required (or be required) Billing & Ins = need to audit to know which way to handle

All 3 don't have to act the same.

This does not block merging existing phone # work to prod behind the feature toggle.

jilladams commented 2 days ago

Pointing as a 5 based on Jordan's level of familiarity. May be lower if Dave picks it up.