department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Next Build Template: Story Listing #19575

Open gracekretschmer-metrostar opened 1 month ago

gracekretschmer-metrostar commented 1 month ago

Template or Content Type

Story Listing

Example

https://dev.va.gov/southern-nevada-health-care/stories/

Description

Overview of template or content type, including relevant details to the migration lift.

Owning Team

Definition of Done

Data:

Interaction / Behavior:

Accessibility:

Visual presentation:

Signoff / Launch

gracekretschmer-metrostar commented 3 weeks ago

10/30: IIR has completed QA review. Did not find any existing launch blockers.

jilladams commented 3 weeks ago

@oddballpete Could you have Adam provide details for us on this ticket re: where Story listings are staged so Sitewide can review?

laflannery commented 1 week ago

Adding here so it's documented:

The results listing has been changed in Next to a true list, using <ul> and <li> elements. This is better for accessibility and it is now aligned with the other results listing markup on the site (Find Forms, Resources, Global). This is a change that, while different from Prod, we should keep.

@jilladams @mmiddaugh @Agile6MSkinner

jilladams commented 1 week ago

@randimays could you update here when you're done with code review, for awareness?

randimays commented 1 week ago

I just finished reviewing the code. No issues found 👍🏻

jilladams commented 1 week ago

@oddballpete @gracekretschmer-metrostar @timcosgrove none of the issues logged in this epic are launch blocking.

This means ~Stories~ Story Listings are cleared to move to Production when y'all are ready. Per the discussion in cross-team sync this week: we'll leave those issues in this epic til Stories AP are in prod, and at that time, we can close this epic and reparent those issues back into the Sitewide board for future consideration.

cc @Agile6MSkinner @mmiddaugh