search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Global: announcement-root div missing #19694

Open laflannery opened 3 weeks ago

laflannery commented 3 weeks ago

Description

In Prod, there is a div directly under the <body> tag with an ID of announcement-root: Image

I had previously found this in the Next footer and called it out as being a difference from Prod. This is a previous screen shot of the Prod footer on the left and the next footer on the right - it shows that this announcement root used to be in the Next footer: Image

However, this div was then removed from the next footer but not put back into the original position above the header. The goal is to make Next as close to Prod as possible, I do not know the purpose of this announcement root div but I want to make sure we have confirmed we do not need this before we remove it entirely

###
- [ ] The problem as described is fixed
- [ ] The repro steps result in 'expected result'
- [ ] An automated test is written to catch the problem, if appropriate

How can we see the problem? (repro steps)

  1. Please include a set of steps that allows an independent tester to see the problem.
  2. Write them so that after the defect is fixed, the steps will result in the expected result.
  3. It is helpful to write the steps methodically so they can be the foundation of an automated test.

Expected result: What should be the outcome?
Actual result: What currently happens?

Is there any additional information?

Screenshots:

Log messages (please specify from where or what commands(s))

Log messages here

Why is the problem happening and how do we fix it?

mcommons10 commented 1 week ago

IIR is including this ticket in our upcoming planning; will ensure property placement / parity with out board

mcommons10 commented 6 days ago

This work has been merged but is pending deployment.