department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[BLOCKED] Meta title for Events is incorrect - the parts are reversed #19698

Open laflannery opened 3 weeks ago

laflannery commented 3 weeks ago

Description

While doing QA for next-build Events I found an existing bug with the <title> tag on Events where the parts are swapped which makes the tag not very helpful.

Currently 3 parts make up the title tag:

  1. H1 of the event
  2. Section the event belongs to (VAMC System name or Outreach)
  3. Website name (Veterans Affairs)

However, on both VAMC Events and National events, Part 1 and 2 are swapped so that the section is coming first. This means that in the browser Tab, I am seeing the Section for all events which is very confusing when I have many open and am trying to find the correct tab to get back to. Notice what my tabs look like currently, I have 4 different events open but I can't use the <title> tag to figure out which one is which:

Image

This is what it should look like: Image

Engineering notes / background

Analytics considerations

Testing & QA

Scope / Impact analysis

What, if anything, could break as a result of this change? Engineer should assess this when approaching PR.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

Acceptance criteria

_ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable._

FranECross commented 2 weeks ago

Blocked so we don't introduce changes before the Staging review of NB Events on 11/15.