department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Fixing Manila Medical Center Break to Next Build #19759

Open gracekretschmer-metrostar opened 1 week ago

gracekretschmer-metrostar commented 1 week ago

User Story or Problem Statement

Next Build should take into account the possibility of missing data so that data problems in the CMS do not cause build problems in Next Build.

Description or Additional Context

Per @timcosgrove:

just a note that the setup of the newly launched Manila medical center has broken Next Build, so I'm working on fixing that.

According to this ticket: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18931

The decision was made to not follow the existing VAMC System / VAMC Facility structure, but to instead make the VAMC Facility the root of the Manila structure and to not have a published VAMC System.

The problem for Next Build here is that for any given facility page with a facility sidebar, we use field_office to locate the menu for that page, and this points to a VAMC System. If the VAMC System is unpublished, there is no data and we cannot grab the menu.

Steps for Implementation

Modify Next Build so that it checks for menu availability before attempting to build the menu.

We will need a follow-up ticket to figure out how to handle the Manila case.

Acceptance Criteria