department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

URL Change for: St. Croix Vet Center Outstation vc_3071OS - Awaiting Redirect #19781

Closed ian-sears closed 4 days ago

ian-sears commented 3 weeks ago

Parent ticket: #17847

What had happened was

Three things:

  1. San Juan: St Thomas VC OS got removed from VAST (vc_3072OS) - no redirect needed. https://www.va.gov/san-juan-vet-center/locations/#st-thomas-vet-center-outstation and https://www.va.gov/san-juan-vet-center/#st-thomas-vet-center-outstation already just load the main VC page
  2. San Juan: St Croix VC OS got removed from VAST (vc_3071OS) - needs a redirect
  3. USVI > St Croix opened (vc_3081OS)

Implementation date

When does this request need to be live: ASAP

Instructions for URL redirect: San Juan St Croix > USVI St Croix

(Note: This issue will be used from initial request through implementation to ensure all individuals working on this are notified of status updates. Please do not create multiple issues to track different steps.)

URL Redirects

Current URL Redirect Destination or New URL
https://www.va.gov/san-juan-vet-center/locations/#st-croix-vet-center-outstation https://www.va.gov/us-virgin-islands-vet-center/#st-croix-vet-center-outstation/

Use one of the following:

1. Canonical URL change: San Juan St Croix > USVI St Croix

Note: Canonical URL changes do not block the completion of the parent ticket. Once the URL redirect above has been deployed, the value to the Veteran is delivered. This ticket should be kept open until the URL change is verified, except in the case of a removal (as described below).

Instructions for canonical URL change

Wait (days or weeks, potentially)

2. Canonical URL removal (if removed from VAST)

Instructions for canonical URL removal

ian-sears commented 3 weeks ago

@omahane These are Outstations. Question: While the Facility ID vc_3071OS (San Juan version) was removed from VAST and the API... The NEW St. Croix Vet Center Outstation was CREATED by VAST with a new Facility ID vc_3081OS (changed that 7 to an 8 ) .. and this new St. Croix Outstation was moved FROM under the San Juan Vet Center TO under the new U.S. Virgin Islands Vet Center. (all of that is done).

Do we (CMS Help Desk) then ask you to REDIRECT, this (Archived, now) url from the san-juan version TO the new St. Croix Virgin Islands version? (or) or do we ask you to REDIRECT this one to a Facility Locations page... as the option.

@department-of-veterans-affairs/platform-cms-helpdesk fysa

ian-sears commented 3 weeks ago

@omahane @jilladams --

When you have some time, could you please Create a URL redirect in the vsp-platform-revproxy repo in template-rendering/revproxy-vagov/vars/redirects.yml

[FROM] https://www.va.gov/san-juan-vet-center/locations/#st-croix-vet-center-outstation/ [TO] https://www.va.gov/us-virgin-islands-vet-center/#st-croix-vet-center-outstation/

Please alert Helpdesk @department-of-veterans-affairs/platform-cms-helpdesk when this step has been completed.

randimays commented 1 week ago

The code for the redirect has been merged and will deploy Monday 11/25 around 9am CST.

randimays commented 6 days ago

The redirect is not working as expected. I believe I know what the issue is. Working on preparing the fix and hope to be able to deploy to production tomorrow instead.

randimays commented 5 days ago

After the new deploy this morning, the redirect is still not working as expected. I think there might be some trouble trying to redirect a URL with a # in it. @ian-sears I noticed that neither:

https://www.va.gov/san-juan-vet-center/locations/#st-croix-vet-center-outstation nor https://www.va.gov/us-virgin-islands-vet-center/#st-croix-vet-center-outstation

jumps to the St. Croix header because there is no ID on that header.

Do we actually want to redirect https://www.va.gov/san-juan-vet-center/locations to https://www.va.gov/us-virgin-islands-vet-center instead?

ian-sears commented 5 days ago

@randimays Thanks. (shrugs). @jilladams Please advise on this case.

Is it appropriate for me to simply Archive this https://www.va.gov/san-juan-vet-center/locations/#st-croix-vet-center-outstation/ in this case?

Facts: It is a closed facility. Its facility API ID was removed from VAST. The NEW facility is up and running, CSV is already resolving (for the new one); essentially all is well except for the consideration of reDirecting this (remember, this is an OUTstation, not a Vet Center or VAMC, or MVC, etc).

jilladams commented 5 days ago

Ahhh, the missing hash header. Yes, that makes sense - thanks Randi, to the page is fine.

randimays commented 4 days ago

@ian-sears I verified in production this morning that https://www.va.gov/san-juan-vet-center/locations now redirects to https://www.va.gov/us-virgin-islands-vet-center. If everything is working as you intend, please close the ticket when ready.

ian-sears commented 4 days ago

This morning, redirect has deployed. https://www.va.gov/san-juan-vet-center/locations/#st-croix-vet-center-outstation now has begun re-directing to https://www.va.gov/us-virgin-islands-vet-center/#st-croix-vet-center-outstation Correct. The link on the page to "Other nearby.." is the convention and all is working as expected now. CSV has deployed and is correct. Closing this URL change as resolved.

Parent ticket: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17847