department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Enable different content moderation (editorial workflow) roles per top-level Section #4965

Open kevwalsh opened 3 years ago

kevwalsh commented 3 years ago

Background

User Story or Problem Statement

A CMS user's content moderation role is the same in every section.

Occasionally, we may want and editor to be able to edit and/or review in one section, but not publish in that section AND be able to edit, review and publish in another section.

How might we allow certain editors to be able to publish content, but only edit or review others?

Example use cases

Discovery questions

Possible implementations

Affected users and stakeholders

Hypothesis

A hypothesis may depend on a spike ticket to be completed.

We believe that _thissolution will achieve _thisoutcome. We'll know that to be true when this measurable outcome occurs.

Assumptions

(How will these assumptions be validated?)

Acceptance Criteria

jenniferlee-dsva commented 3 years ago

Hi @kevwalsh - Adding some additional thinking here based on our discussion last week wrt your suggestion for possibly adding a third dimension for permissions -- i.e., so instead of just sections and user role(s), also possibly adding a tier or product dimension.

After giving it some thought, I think this is really the last resort solution and if possible, one I think we should avoid. The reasons are:

1/ Right now, we have 5 vertical sections - VA, VBA, VHA, NCA, DEPO.

2/ Today, a user can have assignment to multiple vertical sections, but only one role or set of roles.

3/ Is there a way that the BE could allow a person to have assignment to a user role PER vertical section?

Example - so that:

kevwalsh commented 3 years ago

I agree that adding a "Tier" idea is probably the wrong implementation, because the lines are hard to draw and indeed, a VAMC has all 3 "tiers". We are already adding a Product layer to the content model, for a variety of reasons, but i agree that it's probably not suitable for governance.

Before discussing the proposal, just a note about language: sections and their children are all just sections, so i don't think we should start calling top-level sections "Vertical sections" at this stage, and anything below that a "subsection". For now, i'd suggest just calling the top 5 "Top level sections" or something like that. So:

The proposal to distinguish content moderation by access to a "Top level section" proposal is a really interesting one and would warrant a proof of concept. There are some minor UX issues to think through. For example, the current experience for looking at the Owner field would need to change if an editor is looking "across" to another section. And the technical part is not trivial.

This epic would benefit from more discovery and brainstorming. I think we have the user stories we need, not sure if we've thought of all the possible ways of solving for them yet. My sense is that an application-based solution needs to be weighed against a business-process based one, at least in the medium term. (An application-based solution will need some business processes anyway!)

jenniferlee-dsva commented 3 years ago

Mostly agree but couple points of confusion:

VACO user for VBA or VHA can edit and review changes to benefits hubs, but not publish, but can publish changes to content

We mean: VBA, NCA, VHA top level section users can edit/review changes to benefit hub pages (whether or now we move them into the DEPO section), but not have publshing ability to benefit hub pages.

Outreach hub editors can edit outreach hub landing page but not publish those changes. Outreach hub editors can add events and outreach assets and publish them.

(This one feels like it stems from an erroneous smooshing of asset and event data (business line owned data) with web pages and nav menu links (DEPO) owned product -- similar to how PDF forms and forms data are owned by form managers but the form landing pages are DEPO owned.)

jenniferlee-dsva commented 3 years ago

Desired: VACO users for VBA or VHA can edit and review changes to benefits hubs, but not publish those changes.

Content moderation roles: Editor, Reviewer, Publisher. Same for all content products. (Exclude Content Creators from this story.)

EWashb commented 1 year ago

We will most likely be revisiting this work after implementing CMS notifications. Notifications will feed into editorial workflows. Notifications MVP = emails