department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Replace "Audience (tags)" open-ended field with a reference to two existing audience vocabularies #4989

Closed kevwalsh closed 3 years ago

kevwalsh commented 3 years ago

User Story or Problem Statement

Usability testing with editors showed that existing user-generated audience vocabulary was confusing and difficult.

Decision was to replace this with a reference to two other existing controlled Audience vocabularies.

Acceptance Criteria

Implementation steps

at /admin/structure/types/manage/campaign_landing_page/fields/node.campaign_landing_page.field_clp_audience :

Add_between_1_and_3_audiences_settings_for_Campaign_Landing_Page___VA_gov_CMS

at admin/structure/types/manage/campaign_landing_page/form-display

Manage_form_display___VA_gov_CMS

johnhashva commented 3 years ago

@kevwalsh I'd like to include the option to make the "This Page is For" audience component optional in Panel 1. Seems to me the Share links would just move up from there. Does this increase scope by a significant amount?

kevwalsh commented 3 years ago

@johnhashva just saw your last comment today, sorry i missed it!

Making the field optional is trivial.

Are you also suggesting the field get moved from the second panel to the first panel?

johnhashva commented 3 years ago

@kevwalsh Nope. What I was referring to (and this may be a front end thing) -- if the Editor elects not to show _This Page is For component, the Share component -- in effect -- replaces it by moving up -- correct? Would that require any FE work to make that if/then work elegantly?

CLP-Audiences_Share

Question #2: Do you know if there are any plans to add to the Audience taxonomy (adding @brianalloyd in case he knows), which I am putting here for posterity.

Audience Tags Audience Tags - Non

Lastly - can I add a few more Audience tags -- e.g. Lawmakers (or member of Congress) -- or does that go through some sort of approval process with the Content team?

kevwalsh commented 3 years ago

@johnhashva

  1. What I was referring to (and this may be a front end thing) -- if the Editor elects not to show _This Page is For component, the Share component -- in effect -- replaces it by moving up -- correct? Would that require any FE work to make that if/then work elegantly?

Looks like the FE doesn't fail gracefully here, and expects content.

Veteran_Trust_in_VA___Veterans_Affairs
  1. Do you know if there are any plans to add to the Audience taxonomy (adding @brianalloyd in case he knows), which I am putting here for posterity.

I am not aware of any plans. The governance of this taxonomy (or the rest of the R&S product, which triggered the creation of this taxonomy) has not been fully documented.

  1. Lastly - can I add a few more Audience tags -- e.g. Lawmakers (or member of Congress) -- or does that go through some sort of approval process with the Content team?

The "Audience (tags)" vocabulary will be deprecated, leaving only the two other vocabularies (Beneficiaries and non-beneficiaries) above. Content team seems like a good place to ask!

johnhashva commented 3 years ago

@brianalloyd looks we will need to add a ticket to ensure the This Page is For component fails gracefully in event the optional component is de-selected by the CLP editor via CMS. @kevwalsh we would want to make This Page is For active by default and the editor needs to actively disable it.

brianalloyd commented 3 years ago

@johnhashva I'll include this into our "Conditional Rendering" ticket based on a discussion with Kelson this AM and reference this ticket as supporting ticket.