ndouglas
commented
3 years ago Doing a comparison between D8 and D9 without performing database updates causes this class of discrepancy to disappear entirely.
Consequently, the discrepancy seems to be introduced by one of the following database updates performed as part of the upgrade:
---------------------- ------------------------------------- --------------- ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Module Update ID Type Description
---------------------- ------------------------------------- --------------- ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
admin_toolbar_tools 8202 hook_update_n 8202 - Default setting for enable hoverintent.
blazy 8207 hook_update_n 8207 - Added the language manager service as per #3214002.
node_revision_delete 8001 hook_update_n 8001 - Set the default value for the new variable delete_newer.
migrate clear_migrate_source_count_cache post-update Clear the source count cache.
node glossary_view_published post-update Add a published filter to the glossary View.
rest delete_settings post-update Remove obsolete rest.settings configuration.
serialization delete_settings post-update Remove obsolete serialization.settings configuration.
system claro_dropbutton_variants post-update Clear caches due to trustedCallbacks changing in ClaroPreRender.
system entity_revision_metadata_bc_cleanup post-update Remove backwards-compatibility leftovers from entity type definitions.
system schema_version_int post-update Update schema version to integers. @see https:www.drupal.orgprojectdrupalissues3143713
system uninstall_classy post-update Uninstall Classy if it is no longer needed.
system uninstall_entity_reference_module post-update Uninstall entity_reference. @see https:www.drupal.orgprojectdrupalissues3111645
system uninstall_simpletest post-update Uninstall SimpleTest. @see https:www.drupal.orgprojectdrupalissues3110862
system uninstall_stable post-update Uninstall Stable if it is no longer needed. This needs to run after system_post_update_uninstall_classy(). This will be the case since getAvailableUpdateFunctions() returns
an alphabetically sorted list of post_update hooks to be run. @see Drupal\Core\Update\UpdateRegistry::getAvailableUpdateFunctions()
views configuration_entity_relationships post-update Clear errors caused by relationships to configuration entities.
views remove_sorting_global_text_field post-update Clear caches due to removal of sorting for global custom text field.
After studying each of these hooks in turn, I determined that the following hooks were empty and existed only to ensure cache clears:
blazy blazy_update_8207
migrate migrate_post_update_clear_migrate_source_count_cache
system system_post_update_claro_dropbutton_variants
views views_post_update_configuration_entity_relationships
views views_post_update_remove_sorting_global_text_fieldFor the remainder:
admin_toolbar_tools admin_toolbar_tools_update_8202
node_revision_delete node_revision_delete_update_8001
node node_post_update_glossary_view_published
rest rest_post_update_delete_settings
serialization serialization_post_update_delete_settings
system system_post_update_entity_revision_metadata_bc_cleanup
system system_post_update_schema_version_int
system system_post_update_uninstall_classy
system system_post_update_uninstall_entity_reference_module
system system_post_update_uninstall_simpletest
system system_post_update_uninstall_stableI executed the hooks individually to determine their effects on the generated data (still in progress):
admin_toolbar_tools_update_8202 No substantial differences noted.
node_revision_delete_update_8001 No substantial differences noted.
node_post_update_glossary_view_published No substantial differences noted.
system_post_update_entity_revision_metadata_bc_cleanup No substantial differences noted.
rest_post_update_delete_settings No substantial differences noted.
serialization_post_update_delete_settings No substantial differences noted.
system_post_update_schema_version_int No substantial differences noted.
system_post_update_uninstall_classy No substantial differences noted.
system_post_update_uninstall_simpletest No substantial differences noted.Unfortunately, after executing all of the above updates individually, I'm still left with a context export that does not match the context export that I get after running drush updb! So I'm not really sure what's going on here.
Description
In the D8 vs. D9 pages.json diff we see that some links changed from
"routed": trueto"routed": false. Why isn't immediately apparent.The majority of them are the same destination:
But there are a few others as well. I did a quick search to see if there was a simple explanation but didn't find one.
/decision-reviewsexists in both the web and backend.This deserves a deeper look to see if this is the result of a change in how Drupal interprets existing data, if it is because of some issue with the data or our system, etc. This might not affect
vets-websiteat all, but it would be good to find and understand the root cause. It is possible that there might be different root causes explaining this phenomenon in different places, as well.Acceptance Criteria
CMS Team
Core Application Team