department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
96 stars 70 forks source link

Vet Center services added through IEF bypass allow_only_one_validation #5981

Closed swirtSJW closed 6 days ago

swirtSJW commented 3 years ago

Describe the defect When editing a vet_center it is possible to add/create duplicate services even though duplicate service creation is prevented by the allow_only_one field on the content type image

Saving the service directly prevents the creation of duplicate image

However creating using inline entity form does not. image

It is uncertain at this time if this is a bug with IEF or with Allow Only One.

There are some validation issues on the IEF issues board that might be related

  1. https://www.drupal.org/project/inline_entity_form/issues/2926859 (has a patch)
  2. https://www.drupal.org/project/inline_entity_form/issues/2780079 (seems similar but no helpful information)
  3. https://www.drupal.org/project/inline_entity_form/issues/2821343 (likely the result of #1, nothing helpful)

I have created this issue on allow_only_one for use IF this is a bug in that module
https://www.drupal.org/project/allow_only_one/issues/3225757 If it turns out to be an IEF issue that is resolved by the patch, then add a link and note to the allow_only_one issue.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information if relevant, or delete):

Additional context Add any other context about the problem here. Reach out to the Product Managers to determine if it should be escalated as critical (prevents users from accomplishing their work with no known workaround and needs to be addressed within 2 business days).

Labels

(You can delete this section once it's complete)

CMS Team

Please leave only the team that will do this work selected. If you're not sure, it's fine to leave both selected.

kevwalsh commented 3 years ago

Related, will solve this problem in a different way, and improve UX. But also further obscure this defect. https://github.com/department-of-veterans-affairs/va.gov-cms/issues/5888 (fixed in https://github.com/department-of-veterans-affairs/va.gov-cms/pull/5915 )

davidmpickett commented 3 months ago

This defect will be resolved once the IEF changes are implemented. Leaving this defect in backlog to confirm and close after https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18003

jilladams commented 1 month ago

Can be validated / closed when #18003 ships

davidmpickett commented 6 days ago

Verified on Prod Screenshot 2024-08-19 at 1 57 28 PM