department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Do not use deprecated `render()` function #6353

Closed acrollet closed 3 years ago

acrollet commented 3 years ago

Description

All calls to the render() function should be replaced with the render() method on the Renderer service. See https://www.drupal.org/node/2939099

Background

This list may not be complete, it's worth looking for instances called from call_user_func and friends.

acrollet@Agile6-A49-Rollett custom % grep -r ' render(' *|grep -v 'function render' 
va_gov_backend/src/Plugin/field_group/FieldGroupFormatter/DetailsWithImage.php:          '#markup' => render($svg_render),
va_gov_backend/src/Plugin/Block/SidebarMenusBlock.php:      '#markup' => render($build),
va_gov_build_trigger/src/Controller/ContentReleaseStatusBlockController.php:    $output = render($block);
va_gov_consumers/va_gov_consumers.module:      '#markup' => render($readonly_content),
va_gov_consumers/va_gov_consumers.module:    $variables['external_content'] = render($readonly_content);
va_gov_help_center/va_gov_help_center.module:  return render($link);
va_gov_workflow_assignments/src/Plugin/Block/EntityMetaDisplay.php:        $block_items['VA.gov URL'] = render($link);

Implementation

Acceptance Criteria

jefflbrauer commented 3 years ago

Hey team! Please add your planning poker estimate with ZenHub @ElijahLynn @indytechcook @ndouglas @olivereri @timcosgrove

jefflbrauer commented 3 years ago

Please add your planning poker estimate with ZenHub @cweagans