department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 68 forks source link

VAMC top level menu links based on nodes should not be output on VAMC menus #7287

Open kevwalsh opened 2 years ago

kevwalsh commented 2 years ago

Describe the defect

VAMC menus output menu items at the top level of the menu, whether they have paths associated or not.

They should only ever output the three "spokes":

Screenshot Cursor_and_Slack___Threads___Digital_Service___VA___5_new_items

To Reproduce

In a tugboat environment

Steps to reproduce the behavior:

  1. Go to https://prod.cms.va.gov/node/add/health_care_region_detail_page
  2. Add a menu item title "Test unpublished content" with the parent -- VA Pittsburgh health care
  3. Save as draft
  4. Trigger content release
  5. Note the menu item shows up as black in the left nav

Expected behavior

No menu item with a path should show up on the same level as three spokes "Services and locations". "News and events, "About [VAMC] system". (Only <nolink> menu items should show in the first level of the VAMC menu).

Additional context

Some work was done to not show menu items for unpublished content, but that logic doesn't seem to apply to the first level labels.

CMS Team

Please leave only the team that will do this work selected. If you're not sure, it's fine to leave both selected.

kevwalsh commented 2 years ago

Per this slack convo, it may be worth looking at benefits hubs too.

Edit_menu_Careers___employment_benefits_hub___VA_gov_CMS_and_Veteran_Readiness_And_Employment__VR_E____Veterans_Affairs