department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Revisions aren't accurately showing point in time data #8123

Open cmaeng opened 2 years ago

cmaeng commented 2 years ago

Describe the defect

When viewing revisions of pages referencing multiple nodes, the references aren't pulling the versions applicable to the revision's historical time/date stamp but instead seem to be pulling the latest version.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://prod.cms.va.gov/node/29017/revisions
  2. Click on the top most revision dated 7/30/2021 - 16:01pm
  3. Scroll down to 'VAMC system description of service'
  4. You'll see a big black circle icon that wasn't introduced in the content at the facility level until Feb 2022

image.png

Expected behavior

When viewing a prior version of a page, any references would reflect the state they were in at the time of the source page's revision.

Desktop (please complete the following information if relevant, or delete)

Labels

(You can delete this section once it's complete)

CMS Team

Please check the team(s) that will do this work.

swirtSJW commented 2 years ago

This is not likely an easy fix. Will have to dig into this more, BUT this is a core issue and I think is a problem because reverting to a different revision does not, probably should not revert referenced entities to their state. That could get real messy real fast.