department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 68 forks source link

Content audit: Mentions of Direct Upload and its url on VA.gov pages #9219

Closed RLHecht closed 2 years ago

RLHecht commented 2 years ago

Describe the request

Content audits are performed by searching the codebase and compiled site for specific terms. Please provide any context for the audit, and any related terms / alternate spellings, that could return content you are interested in.

We already know it appears on these pages:

Implementation date

When does this request need to be complete?: 6/14 (we need to go live with the changes by 6/30)

Please submit all engineering requests at least 1 full sprint in advance (so we can work it into our next sprint).

CMS Team

Please check the team(s) that will do this work.

wesrowe commented 2 years ago

@ethanteague, you mentioned in slack that "All instances of https://eauth.va.gov/accessva/?cspSelectFor=dmhs appear to be coming from cms. It's not anywhere to be found in content-build or vets-website." Could you say how you determined that – was it a search of those two repos?

ethanteague commented 2 years ago

@ethanteague, you mentioned in slack that "All instances of https://eauth.va.gov/accessva/?cspSelectFor=dmhs appear to be coming from cms. It's not anywhere to be found in content-build or vets-website." Could you say how you determined that – was it a search of those two repos?

That's right, @wesrowe. I did an all files search for the url string in both of my local repos using VsCode.

jilladams commented 2 years ago

1 point

jilladams commented 2 years ago

Meeting scheduled with Tanner on Mon 6/6 to confirm my local setup to grep for results.

jilladams commented 2 years ago

@RLHecht I searched for the phrase "direct upload" and the eauth URL: grep -Rli "Direct Upload" build/localhost > directupload.txt grep -Rli "https://eauth.va.gov/accessva/?cspSelectFor=dmhs" build/localhost > ~/Downloads/directupload2.txt

And that returned this set of pages:

/burials-memorials/eligibility/burial-in-private-cemetery/index.html
/burials-memorials/memorial-items/presidential-memorial-certificates/index.html
/burials-memorials/memorial-items/headstones-markers-medallions/index.html
/disability/dependency-indemnity-compensation/index.html
/disability/upload-supporting-evidence/index.html

The only new paths besides the ones you mentioned already are these:

/burials-memorials/memorial-items/presidential-memorial-certificates/index.html
/disability/dependency-indemnity-compensation/index.html

I sanity checked against a Google search, and I do see several additional VBA forms that include the URL in the form itself via google (e.g. https://www.vba.va.gov/pubs/forms/vba-21-22a-are.pdf). Our audit can't check for contents of files, as far as I know - if those forms are concerns here, let us know and I can see if there is any way to check file contents.

I'll let you close this ticket if you're satisfied here. Thanks!

RLHecht commented 2 years ago

Thanks so much @jilladams We don't need to make updates to forms pages but I can let the stakeholders who asked us to make updates to our pages that there are other mentions of this out there. I can close this ticket.