Flag related notices on facility creation - Githubissues

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.

https://prod.cms.va.gov

GNU General Public License v2.0

99 stars 69 forks source link

Flag related notices on facility creation #9354

Open swirtSJW opened 2 years ago

swirtSJW commented 2 years ago

Describe the defect

Create a new nca facility by hand. See notices (won't be visible on prod)

There is a bug that is throwing notices.

To Reproduce

Steps to reproduce the behavior:

Expected behavior

Facilities get created with no noticed being thrown.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

This is not a bug that anyone will see. But does add some log noise and a possible failure as a result

Labels

(You can delete this section once it's complete)

[x] Issue type (red) (defaults to "Defect")
[ ] CMS subsystem (green)
[ ] CMS practice area (blue)
[x] CMS workstream (orange) (not needed for bug tickets)
[ ] CMS-supported product (black)

CMS Team

Please check the team(s) that will do this work.

[ ] Program
[ ] Platform CMS Team
[ ] Sitewide Crew
[x] ⭐️ Sitewide CMS
[ ] ⭐️ Public Websites
[ ] ⭐️ Facilities
[ ] ⭐️ User support

swirtSJW commented 2 years ago

My hunch is the issue is related to it trying to get revisions on something that has none yet.