department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Events Listing: Using Past events or custom date range filters for dates in the past shows duplicate event recurrences #9454

Closed jilladams closed 2 years ago

jilladams commented 2 years ago

Describe the defect

Listing: Using Past events or custom date range filters for dates in the past shows duplicate event recurrences

e.g. https://www.va.gov/minneapolis-health-care/events/?endDateDay=19&endDateMonth=06&endDateYear=2022&selectedOption=custom-date-range&startDateDay=13&startDateMonth=06&startDateYear=2022

e.g. https://www.va.gov/minneapolis-health-care/events/?endDateDay=14&endDateMonth=06&endDateYear=2022&selectedOption=custom-date-range&startDateDay=08&startDateMonth=06&startDateYear=2022

To Reproduce

Steps to reproduce the behavior:

Expected behavior

Past events or date filters showing past events should only show each recurrence one time.

Screenshots

Screen Shot 2022-06-14 at 1 54 28 PM

Additional context

This example can be a little confusing, as the MN editors have worked around a recurrence limitation by creating 2 of the same events, with weekly recurrences on different days (Mon vs. Wed).

You can test this in Staging for a more clear cut example of what happens for events with recurrences in the past, when using filters.

Labels

(You can delete this section once it's complete)

CMS Team

Please check the team(s) that will do this work.

jilladams commented 2 years ago

Per Dave review in S61 planning, low priority.

jilladams commented 2 years ago

This may also be resolved by #9456

jilladams commented 2 years ago

This was not resolved by #9456 Repro: https://www.va.gov/central-iowa-health-care/events/?selectedOption=past Screen Shot 2022-07-06 at 11 31 44 AM

Moving to stretch / next sprint as an option for FE people to pick up who are looking for work.

maxx1128 commented 2 years ago

@jilladams I'm checking this locally and it's resolved for me. Is it possible the fix wasn't fully pushed to production?

Screen Shot 2022-07-06 at 2 39 59 PM
jilladams commented 2 years ago

Yep, correct -- just confirmed and I had tested right before deploy completed. No longer repros for me - thanks for verifying! Sorry for churn. CLosing.