search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[BLOCKED] [Events] Filters: Custom date range validation does not always display validation error messages when validation error indicators appear #9471

Open jilladams opened 2 years ago

jilladams commented 2 years ago

Describe the defect

When switching between Specific Date and Custom date range filters, entering only the end date (and reusing the existing start date that is prepopulated after setting Specific date), results in validation error bars, but no validation error message.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.va.gov/outreach-and-events/events/
  2. Click on Filter by: Choose specific date
  3. Submit filter on empty form
  4. Filter shows red error bars, but does not show an error message (and should)

Expected behavior

Any validation error bar is accompanied by a validation error message.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

A related but separate ticket requests zeroing out filter values when we switch between filters. (Except for year): https://github.com/department-of-veterans-affairs/va.gov-cms/issues/9473

Labels

(You can delete this section once it's complete)

CMS Team

Please check the team(s) that will do this work.

jilladams commented 2 years ago

@maxx1128 can you confirm if this is still an issue after last week's filter validation fixes?

maxx1128 commented 2 years ago

I can confirm this is still an error, but it should be a pretty easy bug fix.

jilladams commented 2 years ago

Original repro steps

Steps to reproduce the behavior:

  1. Go to https://www.va.gov/outreach-and-events/events/
  2. Click on Filter by: Choose specific date
  3. Submit filter on empty form - red error bar with no validation message appears
  4. Enter a date, Submit
  5. Click on Filter by: Custom date range
  6. Start date is pre-populated from specific date selection
  7. Enter an end date
  8. Submit
  9. Filter shows red error bars, but does not show an error message (and should)

I can't repro this using those steps today. But I can get a repro by submitting the empty date form. Updated in ticket body.

FranECross commented 7 months ago

@FranECross It is a component, but there are three for m/d/y and no unified error message. Create UX ticket and link/block.