department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[BLOCKED] [Events] Hide past events on Event Detail pages so they no longer display #9474

Open jilladams opened 2 years ago

jilladams commented 2 years ago

[2024-08-07] Blocked on AP shipping Events to production, unless it becomes a fire drill.

Describe

Recurring events detail pages, "View other times for this event" panel shows all occurrences, including those in the past, with active "Add to calendar" links.

Per Michelle (7/2024) we should hide all past events from the FE, so that the Veteran/all users only see current/future events. The Government requirement to retain past events doesn't mean we need to display them; it means we need to keep them in the DB/Drupal/available if we need to report on them.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a recurring event with recurrences past and upcoming, e.g. https://staging.va.gov/minneapolis-health-care/events/42754/
  2. Click on View other times for this event
  3. See past dates

Expected behavior

All past events are hidden; only current/future events display https://dsva.slack.com/archives/C52CL1PKQ/p1658422431625569?thread_ts=1658408251.943929&cid=C52CL1PKQ

Acceptance criteria

Screenshots

Current behavior Screen Shot 2022-06-15 at 10 53 26 AM

Desired behavior All past events are hidden image (2)

Labels

(You can delete this section once it's complete)

CMS Team

Please check the team(s) that will do this work.

jilladams commented 2 years ago

Don't want to add past events to calendar. Need to validate expected behavior with Veteran research before we take action. Would want to fold this into a future filter iteration.

randimays commented 6 months ago

Update here: this one is also blocked because we can't use va-icon in content-build yet for this:

Screenshot 2024-04-25 at 11 24 39 AM

Ray said they are nearly finished fixing the issue and are testing today.

jilladams commented 6 months ago

@FranECross do you recall what PM action was needed here?

FranECross commented 6 months ago

@jilladams ~It was to check with Ray to see if the testing was successful. Let me find my Slack message asking and I'll ping them again. I don't believe I got a response.~ I was thinking of a different ticket. I think I was going to create a UX ticket for Jordan, and then spin this one back up after she provided direction. I'll look follow up on this.

jilladams commented 3 months ago

In cross-team sync today, AP requested that unless an issue is burning, they would prefer to push it out by ~1 month. AP is hoping to move Events to production in 2 sprints. Michelle was present and signed off on pulling this out of our sprint with that in mind. Hopefully when we come back to it, we can make this change in AP templates rather than in content-build.

Removing from sprint. FYI @randimays @FranECross

aklausmeier commented 3 months ago

@bethpottsVADEPO FYA