Unescaped apostrophe in CLP CTAs prevents Analytics events from firing

[jilladams]

Describe the defect

A bug was found in the FE code that reports analytics events to Google Analytics. It was initially found to impact three Campaign Landing Pages. Affected CLPs:

• https://www.va.gov/initiatives/veteran-trust-in-va/
• https://www.va.gov/initiatives/veterans-experience-action-centers/
• https://www.va.gov/initiatives/have-questions-before-you-get-your-covid-19-vaccine/ This CLP no longer exists.

Reported impact of bug:

• No impact to site visitors/Veterans
• Events for some links on CLPs aren't recorded
• "Prevents the Medalia feedback button from firing" (per original bug report)

At least one page (Veteran Trust in VA) was fixed by removing the apostrophe from the CTA link. It used to say "Download the VA's Trust Report":

Assessment

It appears that the culprit here is the unescaped apostrophe in the recordEvent event labels.

https://github.com/department-of-veterans-affairs/va.gov-cms/issues/8953 determined that we can escape using the escape filter.

It seems like encode isn't an actual filter for Liquid templating. We'll have to use the escape filter instead. The encode filter also is called here: https://github.com/department-of-veterans-affairs/content-build/blob/f30b05c3db4ef402d10d13d1fedebe7bcee36508/src/site/filters/liquid.js#L827 The only other place that encode is used in the repo is in this file: https://github.com/department-of-veterans-affairs/content-build/blob/f7bafff44f67aea4cffa94ee343d31bbd8784231/src/site/paragraphs/collapsible_panel.drupal.liquid#L39

To Reproduce

Steps to reproduce the behavior:

1. navigate to any of the following pages:
   • https://www.va.gov/initiatives/veteran-trust-in-va/
   • https://www.va.gov/initiatives/veterans-experience-action-centers/
   • https://www.va.gov/initiatives/have-questions-before-you-get-your-covid-19-vaccine/
2. Uncaught SyntaxError in console

Expected behavior

No console errors Click events for CTA's with apostrophes are recorded

Testing analytics is an open question.

Screenshots

Additional context

1. Originally reported to (by?) the analytics team in https://github.com/department-of-veterans-affairs/va.gov-team/issues/40890
2. Assessed for scope of issue/fix in https://github.com/department-of-veterans-affairs/va.gov-cms/issues/8953

Labels

(You can delete this section once it's complete)

• [x] Issue type (red) (defaults to "Defect")
• [ ] CMS subsystem (green)
• [ ] CMS practice area (blue)
• [x] CMS workstream (orange) (not needed for bug tickets)
• [ ] CMS-supported product (black)

CMS Team

Please check the team(s) that will do this work.

• [ ] Program
• [ ] Platform CMS Team
• [ ] Sitewide Crew
• [ ] ⭐️ Sitewide CMS
• [X] ⭐️ Public Websites
• [ ] ⭐️ Facilities
• [ ] ⭐️ User support

[jilladams]

5 points was due to testing analytics (From SPIKE): https://github.com/department-of-veterans-affairs/va.gov-cms/issues/8953#issuecomment-1157055783

[jilladams]

Should this be labeled Icebox? I've forgotten why we moved it back to Unrefined.