search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Silent geocode failures are unactionable #9613

Open swirtSJW opened 2 years ago

swirtSJW commented 2 years ago

User Story or Problem Statement

As a Vet Center CAP editor, If I add an address that does not geocode, I see a notification image But I am helpless to do anything about it, and the lat lon fields remain empty (not able to push to Facility API)

As a Vet Center CAP editor, If I change the address from a "good" address to an address that can not be geocoded, the old lat lon remains in the system so the cms will push the right address but the wrong lat lon to the Facility API, AND I do not know it is happening, AND I am helpless to do anything about it.

Possibile solutions to explore

A) In the event of geocode failure, blank out the lat lon values so we are not pushing incorrect values to Lighthouse. B) In the event of gecode failure, prevent node save??? Given the order of operations, this might not be possible. C) Reveal to editors the map on node View so they can at least see that something is wonky and raise it with cms support. D) compare the address as input by the editor to a database of known, geolocatabale addresses, and offer it as an alternative.

This was uncovered as an issue in https://github.com/department-of-veterans-affairs/va.gov-cms/pull/9584#pullrequestreview-1023467359

Acceptance Criteria

Implementation steps

## Design principles Veteran-centered - [ ] `Single source of truth`: Increase reliability and consistency of content on VA.gov by providing a single source of truth. - [ ] `Accessible, plain language`: Provide guardrails and guidelines to ensure content quality. - [ ] `Purposely structured content`: Ensure Content API can deliver content whose meaning matches its structure. - [ ] `Content lifecycle governance`: Produce tools, processes and policies to maintain content quality throughout its lifecycle. Editor-centered - [ ] `Purpose-driven`: Create an opportunity to involve the editor community in VA’s mission and content strategy goals. - [ ] `Efficient`: Remove distractions and create clear, straightforward paths to get the job done. - [ ] `Approachable`: Offer friendly guidance over authoritative instruction. - [ ] `Consistent`: Reduce user’s mental load by allowing them to fall back on pattern recognition to complete tasks. - [ ] `Empowering`: Provide clear information to help editors make decisions about their work. ### CMS Team Please check the team(s) that will do this work. - [ ] `Program` - [ ] `Platform CMS Team` - [ ] `Sitewide Crew` - [ ] `⭐️ Sitewide CMS` - [ ] `⭐️ Public Websites` - [ ] `⭐️ Facilities` - [ ] `⭐️ User support`
swirtSJW commented 2 years ago

On running the bulk save for these, there are 8 CAPS with addresses that are failing geocoding

Unable to geocode 'Barrio Santa Rosa, Km 1.7 LAJAS, PR 00667 US'.
Unable to geocode 'Carretera 704, Km. 1.6 Interior Barrio Cuyón COAMO, PR 00769 US'.
Unable to geocode 'Callejon Los Fas Casa 9 CABO ROJO, PR 00623 US'.
Unable to geocode 'Urb. Villa del Rosario 6 Street A VEGA BAJA, PR 00693 US'.
Unable to geocode '1 Herrera St. UTUADO, PR 00641 US'.
Unable to geocode 'Pr-3, Kilometers 54.9, Lot 3 Pueblo Ward CEIBA , PR 00735 US'.
Unable to geocode '1000 Recreational Drive MINDEN, LA 71055 US'.
Unable to geocode 'Bldg. 312 on 9th Street DUBLIN, CA 94568 US'.

image