department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

[cms-ci] some SERVER variables are missing #969

Closed swirtSJW closed 4 years ago

swirtSJW commented 4 years ago

Describe the defect Since the move of devshop to a new instance (#916), the new devshop instance does not have any of the environment variables (devshop api key, gov delivery keys...) All the values are empty so things like the frontend build trigger is not working.

To Reproduce Steps to reproduce the behavior:

  1. On any PR environment go to phpinfo page an see that the values are missing.
  2. Go to /admin/content/deploy and trigger a rebuild. Nothing happens.

Expected behavior Build trigger functions Other environment variable dependent items function correctly.

Labels

ElijahLynn commented 4 years ago

Just manually ran drush @hm variable-set devshop_tasks_api_key 12345678987987987987 (not real key) and it is working again.

image

I also added the 2 other keys that were missing until we get on credstash.

swirtSJW commented 4 years ago

Rebuilding the frontend works. I am not sure about other items. Has documentation been created for the next time we deploy a new CI server to make sure these items are covered?

swirtSJW commented 4 years ago

I added a bit of code to make sure the rebuild FE does not fail silently if missing ci data #981

ElijahLynn commented 4 years ago

Rebuilding the frontend works. I am not sure about other items. Has documentation been created for the next time we deploy a new CI server to make sure these items are covered?

We don't plan on doing a manual deploy of the CI server again, and future deploys will be 100% automated. We have the items documented that need to be added to our automated CI server deploys https://github.com/department-of-veterans-affairs/va.gov-cms/issues/916#issuecomment-583172970. If we do a manual deploy by chance, those steps will cover getting them added.