search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Update wrong Korean DMZ date on spina bifida page #1197

Closed jenniferlee-dsva closed 5 years ago

jenniferlee-dsva commented 5 years ago

The Korean DMZ date needs to be updated on this spina bifida page: https://www.va.gov/disability/eligibility/special-claims/birth-defects/

This is factually incorrect and should be made now. It will then need to be made manually in Drupal as part of the post-CMS UAT epic: https://github.com/department-of-veterans-affairs/va.gov-team/issues/1020#event-2562405819

Currently it shows: "A unit in or near the Korean Demilitarized Zone for any length of time between April 1, 1968, and August 31, 1971”

Change to: "... between September 1, 1967, and August 31, 1971."

image

How to configure this issue

jenniferlee-dsva commented 5 years ago

^ please let me know when it goes live, so I can inform stakeholders and ask them to retire their duplicate legacy content.

AnneHurley commented 5 years ago

Here's the updated sentence - but I'm not in Drupal yet alas, so Peggy, is this something you'd be able to change?

Correct:

AnneHurley commented 5 years ago

@peggygannon @mnorthuis @Karak888 @jenniferlee-dsva I wasn't able to tag you all earlier - the copy change in a complete sentence is above -- @peggygannon can you update in Drupal the sentence above, thanks.

peggygannon commented 5 years ago

@AnneHurley Yes, I can review it. Can you add me as reviewer on the Pull request?

also, @jenniferlee-dsva @Karak888 I added this issue to the "post-content freeze drupal updates " epic.

AnneHurley commented 5 years ago

@peggygannon

This is updated now in this branch: pages/disability/eligibility/special-claims/birth-defects.md

I named the branch dmz-date-update Ready for you to publish - thanks for your patience!

peggygannon commented 5 years ago

@AnneHurley ok, thanks. did you create a Pull Request for this change or does that step still need to happen?

aeltarhoni commented 5 years ago

@AnneHurley will be commenting soon!

AnneHurley commented 5 years ago

@peggygannon @jenniferlee-dsva Hi Peggy - apologies if I confused things here - but my understanding was that Peggy, you'd need to add that updated sentence above directly into Drupal because it's an urgent factual fix. I may have confused things by mentioning GitHub below, but Jen had asked this to be done directly in Drupal. Do you still need a pull request for something like this we are doing outside of GH? If so let me know what you need. thanks!

peggygannon commented 5 years ago

@AnneHurley Yes, I'll be making this change in Drupal, once Disability comes out of the content freeze.

We also made the change on the live site (via github) since this was an urgent stakeholder request and want to get the update out asap.

AnneHurley commented 5 years ago

OK thank you so much. Sorry for my confusion and thanks for doing this. I'll move the issue along in its path, then. [image: GovernmentCIO] http://www.governmentcio.com/ Anne Hurley Content Writer | mobile (503) 298-7203 | e. ahurley@governmentcio.com GovernmentCIO website https://www.governmentcio.com/ | media https://governmentciomedia.com/ | services https://www.governmentcio.com/services | jobs https://careers-governmentcio.icims.com/ | map https://www.google.com/maps/place/101+Constitution+Ave+NW+%23100,+Washington,+DC+20001/@38.8927387,-77.0151008,17z/data=!3m1!4b1!4m5!3m4!1s0x89b7b787cdfdb85f:0x1e5a93a8a2b38b03!8m2!3d38.8927345!4d-77.0129121 [image: Twitter] https://twitter.com/GovernmentCIO [image: Facebook] https://www.facebook.com/GovernmentCIOMedia [image: LinkedIn] https://www.linkedin.com/company/governmentcio [image: YouTube] https://www.youtube.com/user/GovernmentCIO/videos [image: Instagram] https://www.instagram.com/gciotalent Confidentiality Note: This email may contain confidential and/or private information. If you received this email in error please delete and notify sender.

On Wed, Aug 28, 2019 at 3:21 PM peggygannon notifications@github.com wrote:

@AnneHurley https://github.com/AnneHurley Yes, I'll be making this change in Drupal, once Disability comes out of the content freeze.

We also made the change on the live site (via github) since this was an urgent stakeholder request and want to get the update out asap.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/department-of-veterans-affairs/va.gov-team/issues/1197?email_source=notifications&email_token=ALDJYXYWTXVYAB7MPYUBCETQG327DA5CNFSM4IOWII2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MUQOY#issuecomment-525944891, or mute the thread https://github.com/notifications/unsubscribe-auth/ALDJYXYOGXBM7PO7DUU6J73QG327DANCNFSM4IOWII2A .