search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Update backend processing that removes ICN #12107

Closed ala-yna closed 3 years ago

ala-yna commented 4 years ago

Given that CARMA could only process veterans as verified or unverified We remove ICN for veterans that aren't found in eMIS.

Once CARMA updates their logic, We can send them ICNs for those individuals To make processing easier.

See: https://github.com/department-of-veterans-affairs/vets-api/blob/master/lib/carma/models/submission.rb#L13


Suggested Solutions 1) Move this business logic to CARMA (have the CARMA devs run the logic on their end, and we always sent the ICN when found). 2) [since CARMA isn't willing to put this logic on their end] Add an additional property to all person's metadata of "personType" that is "VERIFIED_VETERAN" | "NON_VERIFIED_VETERAN" | "PERSON" etc. - what ever their person types are. This is more explicit and less bug-prone.

mlighdc commented 3 years ago

@kevinmirc and @ala-yna is this a duplicate of #12212

ala-yna commented 3 years ago

I'm not sure - @kevinmirc ?

kevinmirc commented 3 years ago

Not a duplicate, this ticket is just a refactor to allow CAMRA to receive the ICN for the veteran but still mark the veteran in CARMA as unverified.

tchrisdyer commented 3 years ago

Closing this unless there is an explicit need by CARMA.