Enable GitHub integration for Sentry

kfrz commented 4 years ago

Issue Description

As an engineer using Sentry to track errors, I can leverage GitHub integration features to track repository changes and link GitHub issues to errors.

Tasks

[x] Create a GitHub application and transfer to the DSVA organization (requires ticket to be filed here)
[x] Put these credentials into credstash, and rename from *.testbed
[x] Configure the deployment playbook to inject configuration values into config.yml.j2
[x] Test build locally with CONFIG="sentry10-utility" APP="sentry10" OPTIONS="-vv" vagrant up --provision, vagrant ssh confirm config is present
[ ] Build new AMI with ansible-playbook -e ref=$REF -e app=sentry10 -e rebuild=true -i inventory build/create.yml
[ ] Test deployment in Jenkins

Acceptance Criteria

[ ] sentry10.vfs.va.gov is running
[ ] Configuration wizard for GitHub integration works in Sentry UI

How to configure this issue

[ ] Attached to a Milestone (when will this be completed?)
[ ] Attached to an Epic (what body of work is this a part of?)
[ ] Labeled with Team (product support, analytics-insights, operations, service-design, tools-be, tools-fe)
[ ] Labeled with Practice Area (backend, frontend, devops, design, research, product, ia, qa, analytics, contact center, research, accessibility, content)
[ ] Labeled with Type (bug, request, discovery, documentation, etc.)

mmiddaugh commented 3 years ago

This came up during a Sentry review meeting today. What's the latest status on this integration @alexpappasoddball ?

alexpappasoddball commented 3 years ago

@mmiddaugh From our side, we are waiting for the Ops team to complete the minor upgrade (which they have already started and are actively working on). From there, Backend tools will finish the configuration to allow for GitHub integration and Slack Integration. Don't have an exact time frame for you yet, but it shouldn't be long now!

mpelzsherman commented 3 years ago

Any updates on this?

jeff2d2 commented 3 years ago

Blocked until #15175 is complete

jeff2d2 commented 3 years ago

According to this Slack thread, GitHub integrations were installed during the upgrade to Sentry 20, and so this work should be complete.

@mleclerc00 can you double confirm for us here please?

mleclerc00 commented 3 years ago

The github integration has always been installed as far as I know even prior to the update to 20.x/migration to kubernetes. The oauth and github integration are both managed through the same github-app "vsp-sentry10-github"

mpelzsherman commented 3 years ago

Getting an error when I try to link a Sentry issue to GitHub:

Screen Shot 2021-06-28 at 4 45 39 PM

Common__Exceptions__BackendServiceException__Common__Exceptions__BackendServiceException_-_vsp_-_platform-api

mpelzsherman commented 3 years ago

BTW, loading data takes a lot longer now than it used to... and seems to error/time out about half the time.

mleclerc00 commented 3 years ago

I will look into the github integration. This predates me and I am not a owner on the app so I have no insight into any of the configurations. When doing the update/migration I merely copy and pasted the configurations that were already there. Though it seems that this never worked? I have reached out to github admins to see if I can get this straightened away. As for the performance issues. We are aware and will be trying to tweak the deployment in order to improve said latency/errors.

mleclerc00 commented 3 years ago

I was able to get one of the two integration installs to work. Not quite sure why there are 2 but I am hesitant to delete the other one. As of right now that particular app only has vision into 3 of the repositories. If that needs to change we will need to speak with a github admin to do so. I haven't actually tried to link a issue but it seems like the rest of the process should work.

department-of-veterans-affairs / va.gov-team