department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Refactor `FeatureFlipper` (not the Flipper you are thinking of) #13879

Open erluti opened 4 years ago

erluti commented 4 years ago

Discovered some mailers are using this code https://github.com/department-of-veterans-affairs/vets-api/blob/509bde20f274f776d1443f4e6e9d402c6ac143e8/lib/feature_flipper.rb, which can easily be confused with the Flipper code we're using. We should rename this class at minimum and discover if this could somehow work as an actual Flipper toggle.

### Tasks
holdenhinkle commented 1 year ago

Consider deleting this module