department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

CT: Update Search Results Page Content #13938

Closed dneel-bah closed 3 years ago

dneel-bah commented 4 years ago

As a comparison tool user, I need the questions and content on the landing page of the tool to clearly communicate the information that is trying to be gathered, so I can accurately answer the questions to get the best results.

Assumptions:

  1. This work is behind a prod flag.
  2. This work is specific to non VETTEC search results.

Acceptance Criteria

  1. The "Refine search" header label is replaced with: "Search by keyword"

  2. Selecting an auto-complete value from the "Enter a school, employer name, city, or zip code" does not cause the search to automatically happen.

  3. A "Search" button is added after the "Enter a school, employer name, city, or zip code" input. a. Clicking the search button will refresh the search results using the filter criteria and free text search.

  4. The following content is added after the "Search" button and before the "Country" input:

    Refine search

    Make changes below to update your results:

  5. The question "Select an institution [type]" answer "Employers only (OJT, apprenticeships)" is replaced with: "Employers (On-the-job training [OJT], apprenticeships)"

    • Note: This will now match the landing page answer value
  6. On mobile: a. Clicking the "Search" button collapses the filters panel and displays the search results. b. The "See Results" button label is replaced with "See Results (NN)" where NN is the current number of results based on the search and filter selections.

  7. The "Institution categories" question label is replace with: "Type of school or employer"

  8. The page matches the layout and structure as specified: a. In Supporting Artifact # 1 when viewed on a desktop device b. In Supporting Artifact # 2 when viewed on a mobile device

Note

Supporting Artifacts:

  1. Desktop Prototype v3 as of 09/23
  2. Mobile Prototype v3 as of 09/23
  3. Content Document v3 as of 09/23
desireeturner commented 4 years ago

We are going to wait to move forward with this work until #13363 (removal of feature flag that some of this functionality is behind) is complete. It has been added as a blocker.

ksantiagoBAH commented 3 years ago

PR: https://github.com/department-of-veterans-affairs/vets-website/pull/14580

delli-gatti-michael commented 3 years ago

Testrail test case: https://dsvavsp.testrail.io/index.php?/cases/view/1025

delli-gatti-michael commented 3 years ago

@department-of-veterans-affairs/uxbah This is on staging and ready for review

watersemma commented 3 years ago

Hey, looking good. Here are a few things I spotted:

  1. Search by Keyword should be updated to H3 1.png
  2. College search box margin should be updated from 3.2 px to 6px to match 2.png
  3. Adjust alignment of 'Exclude results with warnings or closings' checkbox 3.png
  4. Update 'programs' margin from 16 px to 24 px to match 4.png
  5. Military details and housing allowance should each have a 12px margin to give more space after independent study. 5.png
ksantiagoBAH commented 3 years ago

Styling updates PR: https://github.com/department-of-veterans-affairs/vets-website/pull/14631

delli-gatti-michael commented 3 years ago

1 and 2 from the UX feedback are fixed in the PR above. 3-5 should be covered by a separate story

1

Screen Shot 2020-10-20 at 9.26.16 AM.png


2

Screen Shot 2020-10-20 at 9.27.01 AM.png

dneel-bah commented 3 years ago

3&4 are covered in story: #15054. 5 will be left alone until that functionality has gone through another round of usability testing.

delli-gatti-michael commented 3 years ago

@department-of-veterans-affairs/uxbah the updates for 1 and 2 are now in staging

ksantiagoBAH commented 3 years ago

additional PR: https://github.com/department-of-veterans-affairs/vets-website/pull/14655

delli-gatti-michael commented 3 years ago

Local testing complete on PR #3

Screen Shot 2020-10-21 at 10.20.34 AM.png

delli-gatti-michael commented 3 years ago

@department-of-veterans-affairs/uxbah The most recent changes are now live on Staging and ready for review

JenLJ commented 3 years ago

UX Review 1/2: This looks good!

amyknox commented 3 years ago

UX Review - 2/2 Looks great!

delli-gatti-michael commented 3 years ago

Closing this out