department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

[COGNITION] 508-defect-3: Cancel appointment buttons SHOULD have an accessible label #15050

Closed 1Copenut closed 3 years ago

1Copenut commented 4 years ago

508-defect-3

Feedback framework

Point of Contact

VFS Point of Contact: Trevor

User Story or Problem Statement

As a screen reader user, I want to hear a cancel appointment, button announcement that explains clearly what appointment I am canceling. I may be navigating by form elements or buttons and hearing "Cancel appointment, button" over and over requires me to check headings for each appointment so I don't cancel the wrong one.

/cc @peggygannon because there's a content component that she's best suited to advise on.

Details

The upcoming and express care Cancel appointment buttons have incomplete aria-labels. We should improve the aria-label value for upcoming appointments and add a meaningful aria-label for Express Care appointments.

Acceptance Criteria

Definition of done

  1. Review and acknowledge feedback.
  2. Fix and/or document decisions made.
  3. Accessibility specialist will close ticket after reviewing documented decisions / validating fix.

Environment

Code Fix (if known)

! Upcoming Appointments

<button
- aria-label="Cancel appointment"
+ aria-label="Cancel appointment on Monday, November 2, 2020"
  class="vaos-appts__cancel-btn va-button-link vads-u-margin--0 vads-u-flex--0"
>
  Cancel appointment
  <span class="sr-only"> on November 2, 2020</span>
</button>
! Express Care Appointments

<button
- aria-label="Cancel appointment"
+ aria-label="Cancel appointment for Express Care medication or prescription question"
  class="vaos-appts__cancel-btn va-button-link vads-u-margin--0 vads-u-flex--0"
>Cancel appointment</button>

WCAG or Vendor Guidance (optional)

Screenshots or Trace Logs

Screen Shot 2020-10-20 at 9 59 45 AM

peggygannon commented 3 years ago

@jbalboni here's what I recommend use for the Cancel links for the different type of "appts). (So aria label for Express Care would be something like "Cancel Express Care request for neck pain")

cc @rtwell @outerpress, any concerns?

for Appt requests: [Cancel appointment request] for Direct schedule: [Cancel appointment] for Express care: [Cancel Express Care request]

outerpress commented 3 years ago

Those all seem clear to me @peggygannon

jbalboni commented 3 years ago

@1Copenut This should be up on staging now

1Copenut commented 3 years ago

@jbalboni I spot checked this on staging, and the accessible labels are 💯 Moving to close.