Open mchelen-gov opened 3 years ago
One potential improvement is adding a separate .eslintrc
in the src/site/assets/js
folder with rules that are configured to be IE11 compatible.
The configuration cascade works by using the closest .eslintrc file to the file being linted as the highest priority, then any configuration files in the parent directory, and so on. - https://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy
Background: JS syntax that is unsupported by some browsers (such as IE11) can cause errors that prevent the site from functioning. Some JS files are served statically and not run through Babel transpilation.
AC: Automatically verify browser compatibility (such as IE11) for static JS assets in https://github.com/department-of-veterans-affairs/vets-website/tree/master/src/site/assets/js
Possible solutions:
Fix for example issue: https://github.com/department-of-veterans-affairs/vets-website/pull/14772/files