department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

508-defect-4 [COGNITION]: App Directory - Links with same name should have similar purposes #16450

Closed 1Copenut closed 3 years ago

1Copenut commented 3 years ago

508-defect-4

Feedback framework

Definition of done

  1. Review and acknowledge feedback.
  2. Fix and/or document decisions made.
  3. Accessibility specialist will close ticket after reviewing documented decisions / validating fix.

Point of Contact

VFS Point of Contact: Trevor

User Story or Problem Statement

As a user who might choose to expand more than one Additional Information component, I would like the links to have unique text so I can tell what app each link is referring to.

Details

We have three links under each app's additional information pane that have the same text but unique URLs:

It would help us strive for WCAG2 AAA (beyond compliance) if these links had the app's name, so users could distinguish them without additional context like headings.

Acceptance Criteria

Solution (if known)

<a
  class="vads-u-margin-top--2"
  href="https://www.apple.com/legal/privacy/"
  rel="noopener noreferrer"
  target="_blank"
- >View the privacy policy</a>
+ >View the Apple Health privacy policy</a>
<a
  class="vads-u-margin-top--1"
  href="https://www.apple.com/legal/sla/"
  rel="noopener noreferrer"
  target="_blank"
- >View terms of service</a>
+ >View Apple Health terms of service</a>
<a
  class="vads-u-margin-top--1"
  href="mailto:api@va.gov?subject=Report Apple Health to VA"
  rel="noopener noreferrer"
  target="_blank"
- >Report this app to VA</a>
+ >Report Apple Health to VA</a>

WCAG or Vendor Guidance (optional)

Screenshots or Trace Logs

Screen Shot 2020-11-19 at 3 55 51 PM

LeKeve commented 3 years ago

Ready to be tested in production.

1Copenut commented 3 years ago

LGTM. Moving to close.