department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

[DISCOVERY] Translation | Spanish | Corona | Design Implementation Exploration for Links #16923

Closed DanielleThierryUSDSVA closed 3 years ago

DanielleThierryUSDSVA commented 3 years ago

Issue Description

We need to determine if/how we can implement the previously researched design for the translation link.

screenshot of link icon and placement: spanish translation design of link.png

invision mockup of icon and link on a page: https://vsateams.invisionapp.com/share/DCRWYHDNVPM#/screens/362213468


Tasks

image.png

Acceptance Criteria

SKasimow commented 3 years ago

Thanks @DanielleThierryUSDSVA . I'll synch with @youngfreezyVA to investigate.

youngfreezyVA commented 3 years ago

it's definitely doable. here are screenshots as well as link to PR:

Screen Shot 2020-12-05 at 9 33 36 AM Screen Shot 2020-12-05 at 9 33 28 AM

https://github.com/department-of-veterans-affairs/vets-website/pull/15209

DanielleThierryUSDSVA commented 3 years ago

This is fantastic news, @youngfreezyVA .Thank you so much for the quick turnaround!

@batemapf @artsymartha68 keeping you in the loop here re: design discovery for translation link.

batemapf commented 3 years ago

Thanks! This looks great!

SKasimow commented 3 years ago

Yes, great news! Thanks @youngfreezyVA

jenniferlee-dsva commented 3 years ago

All - could you please include @rtwell to validate design? He was the og designer who worked with me on the localization research, and my eye is not trained, but the spacing in the screenshot looks off.

jenniferlee-dsva commented 3 years ago

Also the "n" in espanol is missing the tilda.

youngfreezyVA commented 3 years ago

@jenniferlee-dsva the associated PR was prefixed with WIP and was a discovery ticket. it's not intended to be merged in just yet.

rtwell commented 3 years ago

hello gang! a couple notes:

  1. the spacing on the link for Spanish is too close to the breadcrumb (so much so it kinda looks like part of the breadcrumb). Might we add some space above? I'm thinking something in the neighborhood of 3 spacing units.
  2. the icon should also be blue like the link
DanielleThierryUSDSVA commented 3 years ago

Thanks, @jenniferlee-dsva and @rtwell. And just to make sure we're all aligned: This ticket was just a discovery ticket for @youngfreezyVA to confirm if we could add this icon/link on the front end for the Drupal page. Definitely not intended as the actual implementation. This will go through a design intent review as part of the collab cycle as well. Thanks!

rtwell commented 3 years ago

no problem! thanks, @DanielleThierryUSDSVA

jenniferlee-dsva commented 3 years ago

Thx for that clarification @DanielleThierryUSDSVA. (Sorry to jump the gun.) RE design intent review/collab cycle - will be helpful to make them aware that we went through user research and prototype testing with this prior to there even existing a Platform team (and a collab cycle). Excited to see this move forward.

SKasimow commented 3 years ago

Hi @jenniferlee-dsva - could you point me to the docs for user the research that was conducted and prototype testing? Would love to review these. Thanks.

SKasimow commented 3 years ago

@youngfreezyVA - can you close this now?