department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

QA Feedback - Staging Review - eBenefits [Personalized Career Planning and Growth (CH36)] #17561

Open pjhill opened 3 years ago

pjhill commented 3 years ago

VFS acceptance criteria

Thoughts/questions

Feedback

Must: Ch36 - Copy mismatches: Given that this issue was resolved as invalid because new copy/design changes were implemented, the test cases should be updated to reflect the design changes and re-executed prior to launch in order to validate the design matches the implementation.

Should: None

Consider: CH36 - Unauth'd Vet / Svc Mbr - Copy/Styling:

tlei123 commented 3 years ago

@pjhill , re. the "Must" item...

All previously-failed test-cases now re-run and all Passed.

Test-cases' page-references now updated ("Claimant" -> "Applicant"). At least for my two previously-failed steps in each copy/styling case, the expected-results actually had links to the updated designs, so no need to replace any screenshots there.

@jason-gcio @sporeboy , about the first two "Consider" items:

P.S. @pjhill , finding updating designs here is actually the exception more than the rule -- most of the time, across most Teams, the designs inevitably go stale as further changes are made directly in the product [which is why I've recently started wording my expected-results "Copy/styling should look like this prototype," instead of "...should match this screen."].

jason-gcio commented 3 years ago

Links are definitely a better idea...not sure why I submitted screenshots. Content is always moving! I'll see about switching those over to links, you shouldn't have to do that.

tlei123 commented 3 years ago

I'll see about switching those [screenshots] over to links, you shouldn't have to do that.

Thanks so much, @jason-gcio ! I'll leave this to you then. :)