department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

QA Feedback - Staging Review - "Your VA payment history" - eBenefits #17733

Open ddzz opened 3 years ago

ddzz commented 3 years ago

VFS acceptance criteria

Feedback

Should:

Consider:

tlei123 commented 3 years ago

@ddzz , it's still early days as far as an official VSA Cypress-TestRail integration/process goes, but I'm gonna pilot for this product: #17843

@micahchiang , FYI, as part of Cypress-TestRail integration, I'll be prepending TestRail test-case IDs to your Cypress test-descriptions (the strings inside the it(...)s), and requesting your review & approval of my upcoming PR when ready.

cc @jason-gcio @pjhill

tlei123 commented 3 years ago

[Just moved my comment here to my Crypess-TestRail integration ticket]

tlei123 commented 3 years ago

@ddzz , Should item's been addressed via #17843 .

@cohnjesse @micahchiang , when you add/delete tests to/from view-payments.cypress.spec.js test-file, pls. be sure to either:

Successful TestRail test-run R1536: view-pmts-tr-e2e-test-run-200316

cc @jason-gcio @pjhill