Yellow Ribbon: Incorporate search tips message into YR Search

MarciMcGuireGCIO commented 3 years ago

Issue Description

Add search tips to the Yellow Ribbon search page based on the design that Laurel did - see https://github.com/department-of-veterans-affairs/va.gov-team/issues/17937

Design Reference

Tasks

[x] Add the search tips message to the Yellow Ribbon search page
[x] Add a feature flag to hide on Production
[x] Include the Google Analytics code supplied by the Analytics team here - https://github.com/department-of-veterans-affairs/va.gov-team/issues/18470
[x] QA analytics code with Analytics team on Staging
[x] Staging Peer Review
[ ] Review on Staging with John H and Marci
[x] Remove feature flag
[ ] Deploy to Prod ~Feb 9, 2021

Acceptance Criteria

[ ] A new search tips message will be displayed on the Yellow Ribbon search page

How to configure this issue
[ ] Attached to a Milestone (when will this be completed?)
[ ] Attached to an Epic (what body of work is this a part of?)
[ ] Labeled with Team (product support, analytics-insights, operations, service-design, tools-be, tools-fe)
[ ] Labeled with Practice Area (backend, frontend, devops, design, research, product, ia, qa, analytics, contact center, research, accessibility, content)
[ ] Labeled with Type (bug, request, discovery, documentation, etc.)

MarciMcGuireGCIO commented 3 years ago

Reference design at the bottom of https://github.com/department-of-veterans-affairs/va.gov-team/issues/17937

MarciMcGuireGCIO commented 3 years ago

@zacharymore I added more details to the Tasks at the top of this issue. Pls let me know if it doesn't make sense.

zacharymorel commented 3 years ago

@MarciMcGuireGCIO One question: is this piece of work suppose to incorporate the Search Analytics as well or is it just the tool tip analytics?

MarciMcGuireGCIO commented 3 years ago

@zacharymorel Great question! Just the tool tip analytics. I'll create a new issue in the backlog for incorporating the rest of them.

zacharymorel commented 3 years ago

That sounds good to me. It's another win before we head deep in to back end work on GBCIT data service.

zacharymorel commented 3 years ago

@MarciMcGuireGCIO I need to bump this story points up to a because I'll need to add a new Feature Flag for Yellow ribbon work.

zacharymorel commented 3 years ago

It just occurred to me, we also can create a quick small User Story for 1 point that says, "Adding Yellow Ribbon Enhancements Feature Flag to vets-api" instead if you'd prefer that for documentation. Whatever you prefer!

MarciMcGuireGCIO commented 3 years ago

Hey @zacharymorel let's just bump this story and I'll add it to the tasks at the top.

johnhashva commented 3 years ago

@MarciMcGuireGCIO + @zacharymorel adding the design comp screenshot for visual reference.

MarciMcGuireGCIO commented 3 years ago

@zacharymorel, when you have a few min, can you scan down this Find a Form MVP issue at how the merge and PR info has been connected, and PR-open tags are used: https://github.com/department-of-veterans-affairs/va.gov-team/issues/7691#issuecomment-612955354?

If you could start doing something similar, it will keep John and me in the loop, we can easily go back and see the related PRs, and I can escalate if something is ever blocking us. Thanks!!

zacharymorel commented 3 years ago

To make sure that I understand correctly, you'd like me to add the PR-Open flag to the user story when there is one open?

MarciMcGuireGCIO commented 3 years ago

Yeah! That, and reference the issue number in the pull request so they are linked, like this:

zacharymorel commented 3 years ago

Ah yes! I do link them. There's two Pull Requests linked to user story above.

MarciMcGuireGCIO commented 3 years ago

Oh, I see it now. Sorry about that!

zacharymorel commented 3 years ago

No worries!

MarciMcGuireGCIO commented 3 years ago

I changed my notification for pull requests. No wonder I wasn't seeing them!

zacharymorel commented 3 years ago

@MarciMcGuireGCIO @johnhashva @laurellawrence this should be on staging by 6pm EST today. FYI.

zacharymorel commented 3 years ago

@MarciMcGuireGCIO does this look good to y'all?

zacharymorel commented 3 years ago

https://staging.va.gov/education/yellow-ribbon-participating-schools/?name=University+of+south+florida

MarciMcGuireGCIO commented 3 years ago

Apart from the caps in "Enter A School's full name..." It looks awesome! Unless there was a specific reason for the caps, I think it should read, "Enter a school's full name..." @johnhashva @laurellawrence - thoughts?

zacharymorel commented 3 years ago

Whoops.

zacharymorel commented 3 years ago

I can fix that spelling here in a bit.

zacharymorel commented 3 years ago

Pull request merged. Typo should be fixed on staging by 3.

zacharymorel commented 3 years ago

This is ready for validation and staging review on my end, as far as I know.

department-of-veterans-affairs / va.gov-team