department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

[CONSIDER] Force location name (to avoid heading level defects) #18906

Closed mmiddaugh closed 1 year ago

mmiddaugh commented 3 years ago

Issue Description

the absence of a H4 location name caused a skipped heading level, identified as a 508-defect-2: #15701. The defect has been resolved. However, it was proposed by Ryan to force a location name to avoid causing this issue in the future.

Location names, such as Center for Treatment of Addictive Disorders, (seen within Addiction and Substance Abuse Treatment), use H4 headings, making the H5 for **Hours** and Phone headings appropriate. ![image](https://user-images.githubusercontent.com/55411834/97904272-7890ef00-1cfd-11eb-9ead-3665e64916ee.png) ![image](https://user-images.githubusercontent.com/55411834/97904472-c4dc2f00-1cfd-11eb-85c1-af4626c7f319.png) ![image](https://user-images.githubusercontent.com/55411834/97904135-5008f500-1cfd-11eb-83f8-5993f41e8aa4.png)
Without this H4 location name heading, **Hours** and Phone headings skip a level. ![image](https://user-images.githubusercontent.com/55411834/97905387-1b963880-1cff-11eb-9361-a1440b658cfa.png)

Tasks

Acceptance Criteria

mmiddaugh commented 1 year ago

Should be addressed as part of #13140 VA Services Taxonomy improvements / iterations

jilladams commented 1 year ago

@laflannery FYSA this exists

laflannery commented 1 year ago

@jilladams These headings were worked on in a different ticket to get rid of the skipping heading levels.

jilladams commented 1 year ago

And that satisfies this issue / we're ok to close?

laflannery commented 1 year ago

Yep, I wasn't sure if anyone else (i.e. Michelle) needed to review or be aware but I'll close if you're good!