department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

[WCAG2.1]: Consider adding a performance budget or perf budget guidance to our testing criteria #21181

Closed 1Copenut closed 3 years ago

1Copenut commented 3 years ago

Issue Description

With our new emphasis on mobile-first and WCAG2.1, I'd like to consider adding performance budget recommendations to app work.

Some examples:

Tasks

How to configure this issue

noahgelman commented 3 years ago

After reviewing the current state of performance on VA.gov I've concluded that we do not need to add a performance budget to our testing criteria.

VA.gov is above average in loading speed when compared to other websites. The content on VA.gov is mostly text content based which is not performant intensive. I cannot find any metric that would require us to add performance checks to our testing criteria.

That is not to say there is nothing that can be done to increase performance on the site. There are static assets that could be combined, minified, and cached. Adding height/width to images. Etc. But these are global issues that could be fixed separately to testing criteria and their actual negative impact on the website is minor.

Honestly, VA.gov is the most performant website I've worked on.