search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 198 forks source link

[AXE-CORE]: VAMC - Links must have discernible text #22139

Closed mmiddaugh closed 3 years ago

mmiddaugh commented 3 years ago

508-defect-1 :exclamation: Launchblocker

Feedback framework

Definition of done

  1. Review and acknowledge feedback.
  2. Fix issue.
  3. At message the accessibility specialist when issue is resolved.

Point of Contact

VFS Point of Contact: Trevor

User Story or Problem Statement

Accessibility specialists discovered Nightwatch axe checks failing silently during a recent staging review. Multiple axe violations were discovered where empty link tags were on the pages. These are problematic because screen readers will announce "Link" but not what the link is.

This page has an element in the tab order without accessible text.

This is a content issue: the link is on a space and includes the "safelinks" addon.

image

image

image

Tasks

SgardnerPMP commented 3 years ago

Update

On Thu, Mar 25, 2021, 7:38 AM mmiddaugh @.***> wrote:

508-defect-1 ❗ Launchblocker https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/accessibility/guidance/defect-severity-rubric.md#508-defect-1 Feedback framework

  • ❗️ Must for if the feedback must be applied
  • ⚠️ Should if the feedback is best practice
  • ✔️ Consider for suggestions/enhancements

Definition of done

  1. Review and acknowledge feedback.
  2. Fix issue.
  3. At message the accessibility specialist when issue is resolved.

Point of Contact

VFS Point of Contact: Trevor User Story or Problem Statement

Accessibility specialists discovered Nightwatch axe checks failing silently during a recent staging review. Multiple axe violations were discovered where empty link tags were on the pages. These are problematic because screen readers will announce "Link" but not what the link is.

This page https://www.va.gov/eastern-oklahoma-health-care/news-releases/eastern-oklahoma-va-begins-covid-19-vaccine-distribution/ has an element in the tab order without accessible text.

This is a content issue: the link is on a space and includes the "safelinks" addon.

[image: image] https://user-images.githubusercontent.com/55411834/112392223-ab447f80-8cbe-11eb-831e-4a42610b2bb1.png

[image: image] https://user-images.githubusercontent.com/55411834/112391840-22c5df00-8cbe-11eb-84b7-bdc8885c8dca.png

[image: image] https://user-images.githubusercontent.com/55411834/112490631-2a7c9680-8d45-11eb-9bfc-44a374ad505d.png Tasks

  • If there is no value or HREF, the link should be removed.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/department-of-veterans-affairs/va.gov-team/issues/22139, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANRXCSW5IVCB3VNOF4BJOSDTFNDIBANCNFSM4ZZPQXTA .

SgardnerPMP commented 3 years ago

This detail page was migrated in by CMS, not created by VAMC or reviewed by VAMC content, pushed by VHA Digital media.

We will confirm why this is an actual link or just an underline activation and if has to be resolved on all pages that were migrated.

VAMC will initiated this as a technical debt resolution starting with this system.

Thank you.

SgardnerPMP commented 3 years ago

PAO, has resolved and updated Hyperlink with correct source code and does not reference safelinks add on.

mmiddaugh commented 3 years ago

@1Copenut can you validate this when you are able?

1Copenut commented 3 years ago

@mmiddaugh Yep! Just checked this one and it's linked correctly. Moving to close.