search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

sitewide defect-level-3 [FOCUS]: When closing the "in this section" menu, focus should be placed back on the "in this section" button #22826

Open joshkimux opened 3 years ago

joshkimux commented 3 years ago

508-defect-3

Feedback framework

Definition of done

  1. Review and acknowledge feedback.
  2. Fix and/or document decisions made.
  3. Accessibility specialist will close ticket after reviewing documented decisions / validating fix.

Point of Contact

VFS Point of Contact: Josh

User Story or Problem Statement

As a keyboard user, I expect focus to be circular when opening and closing menus.

Details

When using the "X" close button in the expanded in this section menu, focus is returned to before the in this section menu. It should be placed directly on the in this section menu instead to be circular.

Acceptance Criteria

Example:

Environment

Keyboard

Steps to Recreate

  1. Enter https://staging.va.gov/careers-employment/vocational-rehabilitation/ in browser
  2. Reduce screen width to a tablet viewport ~600-800 (triggers the mobile menu)
  3. Open the in this section menu
  4. Close the in this section menu using enter
  5. Confirm one tab is needed to put focus back on the in this section menu

Proposed Solution (if known)

Place focus back on the in this section menu post closure using keyboard

Screenshots or Trace Logs

https://user-images.githubusercontent.com/14154792/113887917-e307f880-978f-11eb-9ae0-53f753886201.mov

tblackwe commented 1 year ago

@Midge-dev Please take a look when you get a chance and determine if we need to resolve.

tblackwe commented 1 year ago

The sitewide label has me concerned on this one, probably outside the scope of our team.

Midge-dev commented 1 year ago

@tblackwe per our slack conversation, this one can go to va-platform-cop-frontend

steele-lm commented 6 months ago

@lindsay-insco Apologies, but I think this is a platform level component/issue, but I'm not sure the best way to migrate it to your team. I added the platform-cop-frontend label.