department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Review Code Review Requirements for Calls to MPI #23220

Closed joeniquette closed 3 years ago

joeniquette commented 3 years ago

slack conversation here: https://dsva.slack.com/archives/C019S3NSSAD/p1618239519148200 and here: https://dsva.slack.com/archives/CBU0KDSB1/p1618237577267200 and here: https://dsva.slack.com/archives/CBU0KDSB1/p1618234214257100

Essentially this ticket asks that we review all code changes/additions for calls to MPI through va.gov and ensure our team is alerted/forced to approve before the change can go to production.

If you are looking to dive into code review and github actions, this is the ticket for you.

bramleyjl commented 3 years ago

This issue is serving as a mini-epic for adding Identity as codeowners for the MPI lib, adding a validator for calls to the MPI service, and any other improvements to the data we send to MPI that might come up.

The MPI validation functionality is currently blocked pending detailed data specifications from MPI.

bramleyjl commented 3 years ago

MPI validation that is blocking this is planned to be completed in Sprint 53.

bramleyjl commented 3 years ago

MPI validation that is blocking this is planned to be completed in Sprint 54 in coordination with @lihanli .