department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Accessibility Feedback for Staging Review [Claims & Appeals - Notice of Disagreement] #25110

Open joshkimux opened 3 years ago

joshkimux commented 3 years ago

Accessibility Feedback for Staging Review [Claims & Appeals - Notice of Disagreement]

Feedback framework

Definition of done

  1. Review and acknowledge feedback.
  2. Fix and/or document decisions made.
  3. Accessibility specialist will close ticket after reviewing documented decisions / validating fix.

Point of Contact

VFS Point of Contact: Josh and Angela

Pending items that need more review before being written into tickets (once ID.me is fixed)

1. Determine if sandwiched text between interactive elements is easy to miss when using the tab key. Can be addressed by placing instructional language above interactive elements, not below. Potential defect 2.

  1. Determine if focus is being managed well, particularly when it comes to screen reader announcements. May be easier for focus to be placed on an actual input instead of the label/legend/paragraph. Potential defect 2-3.

image image

3. Determine if buttons not having unique labels will present accessibility challenges. Potential defect 3.

4. Determine if a more descriptive label e.g. "Please specify other reasons" is needed. Potential defect 3-4.

Mottie commented 3 years ago

Pending issue updates:

  1. Content added to an additional info dropdown

    Open additional info ![Screen Shot 2021-06-08 at 10 41 15 AM](https://user-images.githubusercontent.com/136959/121216172-4670de00-c846-11eb-9cc2-a138c2b2db1c.png)
  2. No change - awaiting decision

  3. Edit aria-label now includes the issue name (see PR #17508)

    Edit button with updated aria-label ![](https://user-images.githubusercontent.com/136959/121048153-2aa10580-c77c-11eb-953c-2d6cb481af6f.png)
  4. Area of disagreement page content updated

    Other reason content update ![Screen Shot 2021-06-07 at 10 23 06 AM](https://user-images.githubusercontent.com/136959/121216997-08c08500-c847-11eb-8567-a04bc05b0899.png)

    This last one, I'm not sure if the checkbox needs an aria-describedby that points to the "Please specify" input?

joshkimux commented 3 years ago

@Mottie 1, 2, and 4 look great; I don't think we'll need aria-describedby for the checkbox 🥳