search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 201 forks source link

[FE] Profile: We should not attempt to fetch profile info if the user is not in MVI #25442

Closed erikphansen closed 2 years ago

erikphansen commented 3 years ago

When testing locally with user 41, I noticed that the GET user call showed errors with MVI and EMIS. They got a 404 from MVI and 401 from EMIS.

We also got errors from the following endpoints: personal_information, service_history, rating_info, and ch33_bank_accounts.

We should not even call those APIs if the user is not in MVI. We already have the logic in place to block most Profile routes if the user is not in MVI. And we already have logic in place to not make those API calls if the user is LOA1. We should add new logic to not make those API calls if the user is not in MVI.

Screen Shot 2021-06-01 at 8.41.09 AM.png

tmitchellgcio commented 2 years ago

Looks like that user may have been fixed so I'm going to write a test to prove this

tmitchellgcio commented 2 years ago

@ajakabcin Ready for validation

ajakabcin commented 2 years ago

@erikphansen could you take a look at this for validation? not sure this is something I can confirm

erikphansen commented 2 years ago

I don't think we have any test users who are not in MPI, so I'm calling this done.