department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Full Accessibility & 508 Office Audit [Authenticated Experience - My VA 2.0] #28306

Closed ajakabcin closed 1 month ago

ajakabcin commented 3 years ago

Steps to complete the Full Accessibility & 508 Audit:

Artifacts

Additional information

As part of this review, Platform will send your product to VA's 508 office for approval (as applicable).

Please refer to the Platform Collaboration Cycle README on Github for more information about the Collaboration Cycle.

ajakabcin commented 3 years ago

@shiragoodman @noahgelman and @1Copenut - I created this issue to get things pulled together for documentation purposes, but we're still working through a few lingering defects from our original accessibility review. We're not officially ready to have this sent to for the audit as we have some minor issues still open. I'll comment on the ticket when it's ready to proceed to the next step.

Thanks!

shiragoodman commented 3 years ago

thanks @ajakabcin ! Tagging @joshkimux and @AngelaFowler82 for awareness.

ajakabcin commented 3 years ago

Ok @shiragoodman we're good to go on this now. Thanks so much!

cc @joshkimux and @AngelaFowler82

AngelaFowler82 commented 3 years ago

Looking at user+36, it shows that the user has applied for disability compensation and educational benefits, both of which appear in the "Benefits you might be interested section." Is there any way to make the content of "Benefits you might be interested in" more dependent on the benefits the user has applied for?

ajakabcin commented 3 years ago

Hi @AngelaFowler82 - yes we've noticed this, and unless I'm misunderstanding user 36's situation, we have a ticket in our backlog to make this change. I believe the logic currently looks for "active" benefits vs applications in progress to determine whether to show that section or not. Erik caught this earlier this summer and made the recommendation that we adjust that logic to include apps in progress as well as a Veteran actively receiving benefits as scenarios when we should hide the "Benefits you might be interested in" section. See #26652

joshkimux commented 3 years ago

@ajakabcin Big shoutout to the auth exp team for making this one of the smoothest full 508 audits in memory. Angela and I have wrapped this up in record time!

@1Copenut @noahgelman this full audit is complete and is ready for y'alls final review 😄

ajakabcin commented 1 month ago

Closed as complete