department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Staging Review - AFS (was Booz Allen) - GI Bill Comparison Tool #28682

Open amyknox opened 3 years ago

amyknox commented 3 years ago

Steps to complete Staging Review:

Artifacts

Meeting attendees from requesting team

Scheduling

Staging Reviews can only be scheduled on Thursday.

Please select your preferred time slot per the Platform Collaboration Meetings Calendar.

Date/time - New Date request December 2, 2:00 PM

Date/time - (Previous review with BAH) August 26, 1:30 PM

Please note:

Additional information

Please refer to Platform Collaboration Cycle on Platform website for more information about the Collaboration Cycle.

mnorthuis commented 3 years ago

@amyknox Below is IA feedback from today's review:

Launch blocking:

Non-LB

amyknox commented 3 years ago

@mnorthuis Thank you for the feedback!

Couple questions for the following breadcrumb and URL launch blockers:

We're updating the terminal breadcrumb from "School details" to "Institution details." Since we're using "Institution" as the general term for schools, employers & VET TEC providers, the breadcrumb will echo & reinforce that nomenclature.

For the URL, unfortunately, we can't use the institution name and have to use the facility number due to technical constraints. The current syntax is .../profile/[facilitynumber] Given that, would the following syntax be an acceptable approach: .../institution-detail/[facilitynumber]?

amyknox commented 3 years ago

@mnorthuis

Regarding the button inside the "Update tuition and housing estimates" accordion, that button label is intended to be "Update estimates". We caught that incorrect "Update results" label in in a late-cycle design review but the update hasn't made it to staging yet.

When that label is updated to "Update estimates", does it sufficiently address both of these issues you reported?

mnorthuis commented 3 years ago

Hi @amyknox, responses to the above questions

Regarding the breadcrumb and URL feedback

Regarding the "update" buttons

shiragoodman commented 3 years ago

Hi BAH/Education Application team - for the 2nd Staging Review, we will just be validating the launch-blocking issue. If you'd like us to take a look at anything else, please feel free to comment on the ticket and tag the POC/reviewer. You are also welcome to attend Design office hours on Tuesday or Collab Cycle office Hours on Wednesday.

If any links or access information has changed since the first staging review, please let us know and update the main body of the ticket above (do not post in the comments). Thank you!

CC: @WillMcCormack @amyknox

ERRonat0609 commented 2 years ago

@shiragoodman - RE-submitting the original ticket as discussed, with updates to reflect the additional AFS team info.

The following tickets have been closed since AFS took over this project: #29346, #29373, #29370, and #29484. All other defect tickets were closed by BAH prior to their departure.

ERRonat0609 commented 2 years ago

@shiragoodman Per your request, here is the mockup from Ryan for the Notification modal that we are adding, which has pushed our staging review out a week so that we can implement it. Users will see this the first time they access the new CT.

12/3; NOTE: this info has changed, please see the comment at the bottom of this ticket! CT notification image

peggygannon commented 2 years ago

Hi, @ERRonat0609 Please see below for content recommendation for this modal text. Let me know if you have any questions!

We’ve launched a new version of the GI Bill Comparison Tool With this new version you can:

{button} Go to the GI Bill Comparison Tool

ERRonat0609 commented 2 years ago

Update regarding the modal notification mentioned on 11/30 above: due to issues that we have encountered and after discussion with Ryan T, the team has decided to release without this notification, so the modal and text mentioned above will not be included, nor will any other type of notification.

allison0034 commented 2 years ago

@ERRonat0609 I just want to confirm that Link to the tool or feature in staging in the original ticket is still correct

ERRonat0609 commented 2 years ago

@allison0034 Yes, that is the correct link

mnorthuis commented 2 years ago

@ERRonat0609 What is your plan for launch of this tool in regards to it's URL and the production tool? Will you be moving it to the existing production URL and eliminating "sandbox" from the URL?

ERRonat0609 commented 2 years ago

@mnorthuis > What is your plan for launch of this tool in regards to it's URL and the production tool? Will you be moving it to the existing production URL and eliminating "sandbox" from the URL?

Yes, we will be using the same production URL, and once it is live, we will use the same staging URL, minus the "sandbox"

mnorthuis commented 2 years ago

@ERRonat0609 Thank you for that info. This tool was migrated over from vets.gov with the same URL structure, but it is technically incorrect since it doesn't represent the accurate structure. If you are changing the URL of the tools from staging to production (removing the "sandbox" portion), it would be an ideal time to correct the URL issue which will help improve findability/SEO and ensure the navigation system is accurate (breadcrumb doesn't match URL). Is this something that can be done as part of this launch?

Correct URL would be www.va.gov/education/gi-bill-comparison-tool/

It is inserting the accurate sub-directory (/education) where the tool should live.

ERRonat0609 commented 2 years ago

@mnorthuis - I get where you're coming from and I agree that the URL should be fixed, but I have a question: if we changed this URL now, would that affect the information being captured in Google Analytics? cc: @dan-brooking @bsmartin-ep please see Mikki's question above

Also including Manish, our tech lead for this question -- @af-manish would there be any reason to NOT correct the URL when we go live with the new version?

jimuhh commented 2 years ago

filter showing "exclude these types of schools" Here's the screenshot of the mixed filtering behavior noted in staging review IA feedback

ERRonat0609 commented 2 years ago

@jimuhh - fyi, we have a defect ticket from the previous staging review to fix that - as part of #29369

jimuhh commented 2 years ago

@ERRonat0609 -- thanks for letting me know! I saw a closed ticket that referred to a slightly different filter issue but not that one specifically. I'm keeping the issue in the feedback but removing "launch blocker" label by way of acknowledging that it's on your radar.

shiragoodman commented 2 years ago

hey @mrblanco1 and @ERRonat0609 . Per our discussion at the Staging Review today, all issues we found will have the label 2ndStaging so that we can distinguish them from the issues identified at the August BAH Staging Review. You can use this query to see them all. Please let us know if you have questions/concerns about any of the tickets/issues identified. I'll post the recording here as soon as it's available.

shiragoodman commented 2 years ago

Recording of 12/9 Staging Review Passcode: ^$r#WQt6

bsmartin-ep commented 2 years ago

@ERRonat0609 -

if we changed this URL now, would that affect the information being captured in Google Analytics?

No - all of our tagging is based on pushing events to GTM, so we shouldn't see any changes (other than the URL attached to the event the GA). The old tagging is very very dependent on page URL, but the new tagging is much less rigid.