department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[ArgoCD] ArgoCD and secrets #29040

Open dginther opened 3 years ago

dginther commented 3 years ago

Description

ArgoCD thinks that some services which update their own secrets are out of sync.

Background/context

Because these services modify their own secret values, ArgoCD sees them as out of sync with what is in the manifests repo. Taylor tried to add an annotation to ignore changes to this item but it doesn't seem to be working.

There is a way to ignore specific changes in an ArgoCD Application Resource (kind: Application) of which there is an example here: https://github.com/DoubleGin/infrastructure/blob/master/k8s/argocd/applications/application-istio.yaml

The difficulty level here is that our Application Resources are defined in Jsonnet, which may complicate adding this to the spec. https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/blob/main/jsonnet/lib/argocd-application.libsonnet


Tasks

Acceptance Criteria


Reminders

jbritt1 commented 2 years ago

Could this perhaps also be solved if we went the route of version pinning secrets in application manifests for department-of-veterans-affairs/va.gov-team#29036?