Closed brianalloyd closed 9 months ago
@davidconlon any update on this footer change? Last word from @mnorthuis was you are investigating.
We are approved to remove it, this is now waiting on me to figure out where we link to it instead. So please hold...a bit longer. :-)
@brianalloyd @mnorthuis While we are not legally required to keep the link, we should have a home for this somewhere. @mnorthuis @rtwell any ideas?
Will do @mnorthuis, thanks for update.
@davidconlon This is a tough one, because in the end, the Veteran Portrait Project is not a VA project or program, its external and not affiliated. At the same time, we are using the photos and need to provide credit for their source.
I was wondering if its possible to link the image itself to the content? Is that even a possibility? Is it an accessibility issue? Do you hate the idea?
This isn't a gov program, its an effort of a private citizen, so its place in the footer is even a bit weird. It definitely does not belong in the top nav. I can't find any other content across the site that seems like a good place for this, but maybe you know of a department or content that I'm not thinking of?
Decision point is to keep this for now. No action needed at this time.
@mnorthuis Should we still keep this item open? I see that the link is still in the sub-footer. Thanks!
Let's close this in lieu of the header/footer work. This can be tackled appropriate with that effort.
Thanks a bunch, @mnorthuis !
Why you're here
Seperated workflow from ticket Footer Changers from IA #29528
Engineering support for:
Note: Apps teams engineers are responsible for flipper implementation related to their products. Our engineers can provide consultation as needed. Read feature toggle documentation
How to submit your request
When to submit your request
Please submit all engineering requests at least 1 full sprint in advance (so we can work it into our next sprint).
About your app/tool/functionality
About your support needs
Please select all that apply, and follow related guidance.
Frontend engineering support
[ ] Implementation of REACT sign-in widgets
Full spec including different states and behaviors:
Flipper unique id:
[ ] Support for UAT testing or phased roll out of app/tool landing page
Full spec including different states and behaviors:
Flipper unique id:
Note: Apps teams engineers are responsible for flipper implementation related to their products. Our engineers can provide consultation as needed. Read feature toggle documentation
These updates can be done at any time
This change is waiting confirmation before implementation
Desired/target implementation date
What's the ETA for the app/tool launch or the date when you need this request completed? Our team's capacity will determine which sprint the work falls into.
Note: As a best practice, PW does not release new products over weekends or holidays. Please plan accordingly.
Appendix
Ensure your code changes are covered by E2E tests (expand)
- Add E2E tests if none exist for this addition/change. - Update existing E2E tests if this code will change functionality. - Include axe checks, including hidden contentRun axe checks using the Chrome or Firefox browser plugin (expand)
- Ensure no heading levels are skipped. - Ensure all buttons and labeled inputs use semantic HTML elements. - Ensure all buttons, labeled elements and images are identified using HTML semantic markers or ARIA roles. - Ensure form fields have clearly defined boundaries or outlines. - Ensure form fields do not use placeholder text. - Ensure form fields have highly visible and specific error states.Test for color contrast and color blindness issues (expand)
- All text has appropriate contrast.Zoom layouts to 400% at 1280px width (expand)
- Ensure readability and usability are supported when zoomed up to 400% at 1280px browser width - Ensure no content gets focused offscreen or is hidden from view.Test with 1 or 2 screen readers (expand)
- Ensure the page includes a skip navigation link. - Ensure all links are properly descriptive. - Ensure screen reader users can hear the text equivalent for each image conveying information. - Ensure screen reader users can hear the text equivalent for each image button. - Ensure screen reader users can hear labels and instructions for inputs. - Ensure purely decorative images are not announced by the screenreader.Navigate using the keyboard only (expand)
- Ensure all links (navigation, text and/or image), form controls and page functions can be reached with the tab key in a logical order. - Ensure all links (navigation, text and/or image), form controls and page functions can be triggered with the spacebar, enter key, or arrow keys. - Ensure all interactive elements can be reached with the tab key in a logical order - Ensure all interactive elements can be triggered with the spacebar, enter key, or arrow keys. - Ensure focus is always visible and appears in logical order. - Ensure each interactive element has visible focus state which appears in logical order.How to configure this issue
product support
,analytics-insights
,operations
,service-design
,tools-be
,tools-fe
)backend
,frontend
,devops
,design
,research
,product
,ia
,qa
,analytics
,contact center
,research
,accessibility
,content
)bug
,request
,discovery
,documentation
, etc.)