department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

Staging Review [VANotify/VEText - Digital Notifications Terms & Conditions page on VA.gov] #29933

Open miabecker opened 3 years ago

miabecker commented 3 years ago

Steps to complete Staging Review:

Artifacts

http://preview-prod.vfs.va.gov/preview?nodeId=34307

https://github.com/department-of-veterans-affairs/va.gov-team/issues/25887

Meeting attendees from requesting team

Scheduling

Staging Reviews can only be scheduled on Thursday.

Please select your preferred time slot per the Platform Collaboration Meetings Calendar.

Date/time

Thu, September 16, 2:00pm – 2:30pm

Please note:

Additional information

Please refer to Platform Collaboration Cycle or the Staging Review Touchpoint on Platform website for more information about the Collaboration Cycle.

shiragoodman commented 3 years ago

hey @miabecker - we don't have availability on 9/16 (plus it's not within our 4 day window). Can you do 2:00pm on 9/23?

miabecker commented 3 years ago

Yes! Apologies I misread the calendar - and yes we were trying to squeeze in sorry!

On Tue, Sep 14, 2021 at 5:07 PM shiragoodman @.***> wrote:

hey @miabecker https://github.com/miabecker - we don't have availability on 9/16 (plus it's not within our 4 day window). Can you do 2:00pm on 9/23?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/department-of-veterans-affairs/va.gov-team/issues/29933#issuecomment-919513328, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTMDOZAOHMFJOCT3YQMHTLUB62Q5ANCNFSM5EA4HILA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Maria Becker Product Manager Pronouns she/they Email @.*** Telephone +1 234 567 8910 <+1+234+567+8910> [image: Thoughtworks] http://www.thoughtworks.com/?utm_campaign=maria-becker-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator https://www.thoughtworks.com/careers/lgbtqia-in-tech?utm_source=email-signature&utm_medium=email&utm_campaign=brand

shiragoodman commented 3 years ago

no problem @miabecker ! The staging review has been scheduled for 9/23 at 2:00pm ET

allison0034 commented 3 years ago

@miabecker I see there is no product outline or link in staging. Can you please provide that asap?

miabecker commented 3 years ago

Hi @allison003 you can use the preview URL link http://preview-prod.vfs.va.gov/preview?nodeId=34307 as drupal pages don't go into standing. Also not sure we need a product outline for a new page on VA.gov. But please let me know! : )

shiragoodman commented 3 years ago

thanks @miabecker . You don't need a product outline, but we ask for that because it allows us to see what's in scope for the review. If this is a brand new page, we know the whole things in scope, but when it's iterations to products (esp products that are services or tools) it's hard to us to know where the boundaries are.

We should be good. thank you!

miabecker commented 3 years ago

Thank you for clarifying. Really appreciate it!

On Mon, Sep 20, 2021 at 12:55 PM shiragoodman @.***> wrote:

thanks @miabecker https://github.com/miabecker . You don't need a product outline, but we ask for that because it allows us to see what's in scope for the review. If this is a brand new page, we know the whole things in scope, but when it's iterations to products (esp products that are services or tools) it's hard to us to know where the boundaries are.

We should be good. thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/department-of-veterans-affairs/va.gov-team/issues/29933#issuecomment-923104676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTMDO7NBPGCWTUFUEUL3E3UC5RRLANCNFSM5EA4HILA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Maria Becker Product Manager Pronouns she/they Email @.*** Telephone +1 234 567 8910 <+1+234+567+8910> [image: Thoughtworks] http://www.thoughtworks.com/?utm_campaign=maria-becker-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator https://www.thoughtworks.com/careers/lgbtqia-in-tech?utm_source=email-signature&utm_medium=email&utm_campaign=brand

mnorthuis commented 3 years ago

@miabecker Is there also a draft of the Privacy policy page showing the addition of a link to this page on it? That was the primary entry point and should be represented at staging review as well.

FYI, the breadcrumb on the page is inaccurate and I cannot verify the URL in preview, so right now those 2 items would be launch-blocking issues. If you can confirm the URL used here, that will help, but please know the breadcrumb is currently in accurate.

IA info was here for reference: https://github.com/department-of-veterans-affairs/va.gov-team/issues/26923

miabecker commented 3 years ago

Thats a great question I'm not sure. @DanielleThierryUSDSVA @shiragoodman is there a way to see the entry into this page?

shiragoodman commented 3 years ago

sorry, @miabecker I'm not aware. Also I think you tagged the wrong Danielle above. Did you mean to tag @DanielleThierryUSDSVA ?

miabecker commented 3 years ago

Yes, apologies fixed!

DanielleThierryUSDSVA commented 3 years ago

Hi @miabecker @mnorthuis @shiragoodman. To help answer questions:

DanielleThierryUSDSVA commented 3 years ago

@mnorthuis Here's the preview of the privacy page with the link added. If you have thoughts on changing where this link is in the link order, totally open to those thoughts. Thanks! http://preview-prod.vfs.va.gov/preview?nodeId=712

noahgelman commented 3 years ago

@shiragoodman No accessibility issues.