department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

508-defect-2 [FOCUS]: Focus should be sent to the `h1` upon closing the modal #30029

Open shiragoodman opened 3 years ago

shiragoodman commented 3 years ago

General Information

VFS team name

eBenefits

VFS product name

Dependency Verification

Point of Contact/Reviewers

Josh Kim (Accessibility)


Platform Issue

No VA.gov Experience Standard for the issue found.

Issue Details

Upon closing the modal, focus should not be sent to the skip to content link or breadcrumb.

Link, screenshot or steps to recreate

close-modal-focus

VA.gov Experience Standard

Category Number 00, Issue Number 00

Other References


Platform Recommendation

Focus should be sent to the h1 by giving the h1 a tabindex="-1". By doing so, screen reader users will immediately know what page they are on e.g. "Your VA Dependents" instead of having to listen to a long breadcrumb e.g. "Breadcrumb home... view or change your dependents... your va dependents".

VFS Team Tasks to Complete

shiragoodman commented 3 years ago

@joshkimux can you rename the title of this ticket? You can delete all the text (minus the 00.00.1 number) and rename to the issue you found. thanks!

joshkimux commented 3 years ago

Done!