[FE] Address Content Change feedback

[mdewey]

Related Documentation

these should be links to feature docs

• Sketch
• Product Docs
• Comments

Description

this should be an understandable description of the ticket. This description should have enough context meaning that non-technical team members should get the idea.

Address content change from UA

Tasks

this is a list of technical tasks that need for this ticket

• [x] Ineligible wording
• [x] "identity verification" wording
• [x] Add Facailty name to appointment card
• [x] spacing between the last 4 field and the continue button is a little tight.
• [x] Create unit tests
• [x] Create e2e tests
• [x] Update relevant documentations
  • [x] README
  • [x] Use Cases

Acceptance Criteria

when is the ticket done

• [x] Passes Accessibility checks using axe
• [ ] Deployed to staging.
• [ ] Designer has signed off on the feature
• [ ] Product team has signed off on the feature

[mdewey]

New wording

[brianseek]

@kristenmcconnell this is ready to review in screenshots. I have them attached to the PR here: https://github.com/department-of-veterans-affairs/vets-website/pull/19010

[kristenmcconnell]

@ytsaoca Screenshots are available for review here as well.

[ytsaoca]

@mdewey The content looks good. @brianseek Could you make the facility and clinic information as Heading / H6. (Like what it is shown on the Sketch) Thanks

cc. @kristenmcconnell

[brianseek]

@mdewey The content looks good. @brianseek Could you make the facility and clinic information as Heading / H6. (Like what it is shown on the Sketch) Thanks

cc. @kristenmcconnell

Do you want the text wrapped in an H6 HTML tag? If so, I don't think that this would be a proper heading level for this content. There are no H3 - H5 headings proceeding it. If you just mean from a text style point of view, I think H6 style seems too small from what I see in the design system. https://design.va.gov/utilities/font-size

Please let me know if I am miss-understanding something.

Edit: Nevermind. My eyes are playing tricks on me. The size is what you are looking for after reviewing the sketch file. I will get that updated.

[kristenmcconnell]

@ytsaoca @brainseek I see that it is an H6 style in the Sketch file. We should discuss. It isn't semantic markup to skip headings levels and we want to stick with design system styles. We could go with body copy; otherwise, it should be an H3.

[ytsaoca]

@brianseek @kristenmcconnell Got you. I understand it isn't semantic markup to skip H3 - H5. I think it's good to go with body copy. Thanks!

[brianseek]

@ytsaoca Sorry for the misunderstanding on my part. I updated the type size for Clinic and Facility to match sketch. See screenshots below:

[ytsaoca]

@brianseek Looks good! Thank you!

cc. @kristenmcconnell