Open shiragoodman opened 2 years ago
I discussed this issue with @Saraharaba8, and it appears that this ticket is related to the page footer links. We should inform the site-wide team if I this is correct.
Our HLR form does include some download links within the additional info
expandable components opened by "Why isn’t my issue eligible?" and "Don’t see the issue you’re looking for?" links. So this may still apply to those since no aria-label
was included; but I did follow this previous recommendation (https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/152#issuecomment-553127340).
@brianalloyd per the comments above and conversation with Sitewide Content, I've added your teams label to this ticket. As always, please do not close this out until the issue has been resolved. If you have questions, please let me know. Thanks!
Thanks @shiragoodman this is definitely in our wheelhouse and will prioritize ticket accordingly. Thanks for looping me into the details.
@Mottie I've removed hlr
label from here as I've double checked the download links and they're looking golden. Please continue following Jen's awesome guidance 👏
@Saraharaba8 thanks for flagging this! This is a great catch 💯 👏
I've made small tweaks to the recommendation based on previous fixes we've made on VA.gov and WCAG best practice guidance. Specifically:
Reference our a11y presentation on links for more on user scenarios (google slides)
Your VA Welcome Kit (opens in new window)
(opens in new window)
string, consider using an icon with an aria-label
so sighted users still have an indication that this may open in a new window.aria-label
hey @joshkimux - again, if this isn't related to HLR, we need to know what product is is related to. please let me know!
@FranECross I've reviewed this issue and it's referring to links in the footer - if they open in a new how, how they should be showed and coded, etc.
Based on the current state of things and the fact that the footer is soon-ish (relatively speaking) going to be a component built by the DST, I want to say that:
Assuming those 2 things are accurate - what should we do with this ticket? Move it to blocked? Are we able to close it? It is already 2 years old at this point
@laflannery Thanks so much for reviewing. I'll Ice Box the ticket until the footer is enhanced/componentized/requests in this ticket are moot and then we can close the ticket.
@FranECross Should this be moved to DST folks?
@laflannery Good call. I'll post the link to Carol and ask that they transfer it. Thanks!
Messaged Carol in Slack asking her to take this ticket https://dsva.slack.com/archives/C01DBGX4P45/p1730221830069189
Status
[2024-07-12] [Fran] This ticket on hold until the DS team componentizes the footer, at which time we can retest and close is issues have been resolved. Note that we (the Sitewide Team) should not close this ticket until issues are resolved.
General Information
VFS team name
Claims & Appeals
VFS product name
HLR V2
Point of Contact/Reviewers
Sarah Koomson (@Saraharaba8) - Accessibility Josh Kim (@joshkimux) - Accessibility
Platform Issue
Your content doesn't use correct and consistent labels across links, entry points, navigation components, and H1s.
Issue Details
Links should not open in a new tab or window (WCAG G200)
Reference our a11y presentation on links for more on user scenarios (google slides)
Two scenarios may exist in which they may be necessary. Specifically:
If necessary based on the prior scenarios
Your VA Welcome Kit (opens in new window)
(opens in new window)
string, consider using an icon with anaria-label
so sighted users still have an indication that this may open in a new window.aria-label
Link, screenshot or steps to recreate
VA.gov Experience Standard
Category Number 08, Issue Number 02
Other References
WCAG SC 2.4.6_AA
Platform Recommendation
Include screen reader only elements to links
VFS Team Tasks to Complete